chore: update tools.json #3457
chore: update tools.json #3457
Conversation
asyncapi-bot
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request introduces modifications to two configuration files: Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3457 +/- ##
=======================================
Coverage 70.18% 70.18%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 466 466
Misses 198 198 ☔ View full report in Codecov by Sentry. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3457--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (4)
config/all-tags.json (1)
1-1: Consider maintaining distinct colors for different technologiesWhile standardizing colors (
bg-[#61d0f2]andborder-[#40ccf7]) creates visual consistency, it might make it harder for users to distinguish between different technologies at a glance. Consider maintaining some color variation while still keeping a cohesive palette.config/tools-automated.json (3)
Line range hint
407-439: Fix inconsistencies in GitHub Actions sectionThere are several issues in the GitHub Actions section:
- Inconsistent category names: "github-action" vs "github-actions"
- Duplicate entries for "GitHub Action for Generator"
- Inconsistent descriptions between similar entries
Suggested fixes:
- Standardize category to "github-action"
- Remove duplicate entry
- Ensure consistent descriptions for related tools
Line range hint
721-826: Standardize language field format and valuesThe language field in template entries has several inconsistencies:
- Inconsistent format: some entries use string (
"language": "javascript"), others use array ("language": ["javascript"])- Incorrect language attribution: Java templates are marked with JavaScript as their language
Suggested fixes:
- Standardize language field format (prefer array format for consistency)
- Correct language values to match the actual template language:
- "language": ["javascript"], + "language": ["java"], "technology": [ "Spring Cloud Streams", "Maven" ],
Duplicate entries and inconsistent fields need to be addressed
Several issues were identified in the tools-automated.json file:
Duplicate tool entries across sections:
- AsyncAPI CLI appears in both "CLIs" and "Others"
- AsyncAPI.Net appears in both "Code-first tools" and "Validators"
- GitHub Action for Generator appears twice in "GitHub Actions"
- SIO-AsyncAPI appears in both "APIs" and "Code-first tools"
- ZenWave SDK appears in multiple categories
- Zod Sockets appears in multiple categories
Inconsistent field formats:
- Language field uses both string and array formats (3 arrays vs 25 strings)
Category naming inconsistencies:
- Both "github-action" and "github-actions" are used
- Some categories appear redundant or could be consolidated
Recommendations:
- Remove duplicate tool entries or consolidate them under the most appropriate category
- Standardize the language field to consistently use string format
- Normalize category names (e.g., standardize "github-action" vs "github-actions")
🔗 Analysis chain
Line range hint
1-900: Verify file structure and cross-referencesLet's verify the overall structure and cross-references in the file.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for duplicate entries across sections echo "Checking for duplicate entries..." jq -r '.[] | select(.toolsList != null) | .toolsList[] | .title' config/tools-automated.json | sort | uniq -d # Check for inconsistent category names echo "Checking for inconsistent category names..." jq -r '.[] | select(.toolsList != null) | .toolsList[] | .filters.categories[]' config/tools-automated.json | sort | uniq -c | sort -nr # Check for inconsistent language field formats echo "Checking language field formats..." jq -r '.[] | select(.toolsList != null) | .toolsList[] | select(.filters.language != null) | .filters.language | type' config/tools-automated.json | sort | uniq -cLength of output: 1131
| "title": "AsyncAPI Server API", | ||
| "description": "Server API providing official AsyncAPI tools", | ||
| "links": { | ||
| "websiteUrl": "https://github.com/daler-rahimov/sio-asyncapi", | ||
| "docsUrl": "https://github.com/daler-rahimov/sio-asyncapi", | ||
| "repoUrl": "https://github.com/daler-rahimov/sio-asyncapi" | ||
| "websiteUrl": "https://api.asyncapi.com/v1", | ||
| "docsUrl": "https://api.asyncapi.com/v1/docs", | ||
| "repoUrl": "https://github.com/asyncapi/server-api" | ||
| }, | ||
| "filters": { | ||
| "language": "Python", | ||
| "technology": [ | ||
| "Socket.IO", | ||
| "Flask" | ||
| "Node.js", | ||
| "TypeScript" | ||
| ], | ||
| "categories": [ | ||
| "code-first", | ||
| "api" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": false | ||
| "isAsyncAPIOwner": true |
There was a problem hiding this comment.
Remove duplicate entry for SIO-AsyncAPI
The tool "SIO-AsyncAPI" appears in both the "APIs" and "Code-first tools" sections. Consider keeping it in the most appropriate section to avoid confusion.
Also applies to: 26-45
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Changes