Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add links and correct spelling in ExpenseBreakdown component #2503

Closed

Conversation

kumarsantosh3914
Copy link

  • Added anchor links to improve navigation in ExpenseBreakdown sections
    • Mentorship Program
    • Bounty Program
    • Events
    • Swag Store
    • Hiring
    • Services
  • Corrected minor spelling error in 'Hiring' section ('on our team' to 'on our team')

Closes #2482

Description
This pull request enhances the ExpenseBreakdown component by adding anchor links to each section for improved navigation. Users can now easily access specific information by clicking on the corresponding links. Additionally, a minor spelling error in the "Hiring" section has been corrected. Local testing has been performed to ensure the changes function as expected.

  • ...
  • ...
  • ...

Related issue(s)

Copy link

netlify bot commented Dec 24, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b23c67e
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65aa8a129bfffd00082a3422
😎 Deploy Preview https://deploy-preview-2503--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 24, 2023

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 The subject "Add links and correct spelling in ExpenseBreakdown component" found in the pull request title "feat: Add links and correct spelling in ExpenseBreakdown component" should start with a lowercase character.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 24, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 44
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2503--asyncapi-website.netlify.app/

@akshatnema
Copy link
Member

We already have PR for #2482 , hence closing this PR. @kumarsantosh3914 Kindly work on some other issue to contribute to the project.

@akshatnema akshatnema closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add links to components of expense breakdown
3 participants