feat: added relevant links to expense breakdown components and fixed a minor typo #2482 #2507
Conversation
SwetanshuSingh
requested review from
derberg,
akshatnema,
magicmatatjahu,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
SwetanshuSingh
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2507--asyncapi-website.netlify.app/ |
|
@Mayaleeeee @akshatnema Can you review this PR? |
|
@SwetanshuSingh Kindly resolve the merge conflicts in your PR. |
|
@akshatnema resolved |
| @@ -22,7 +23,7 @@ export default function ExpenseBreakdown() { | |||
| <div className="text-darkGunMetal"> | |||
| <div className="flex flex-col items-center"> | |||
| <img src="/img/illustrations/MentorshipProgram.webp" alt="Mentorship Program" className="w-1/5 h-auto object-cover rounded-md m-1" /> | |||
| <h2 className="text-2xl font-semibold my-2 text-center text-darkGunMetal">Mentorship Program</h2> | |||
| <h2 className="text-2xl font-semibold my-2 text-center text-darkGunMetal hover:underline cursor-pointer"><Link href="https://www.asyncapi.com/blog/beyond-boundaries">Mentorship Program</Link></h2> | |||
There was a problem hiding this comment.
Links should be added to the whole Card, not only to the Card Title.
There was a problem hiding this comment.
@akshatnema added the suggested changes
| <div className="text-darkGunMetal"> | ||
| <div className="flex flex-col items-center"> | ||
| <img src="/img/illustrations/MentorshipProgram.webp" alt="Mentorship Program" className="w-1/5 h-auto object-cover rounded-md m-1" /> | ||
| <h2 className="text-2xl font-semibold my-2 text-center text-darkGunMetal hover:underline cursor-pointer">Mentorship Program</h2> |
There was a problem hiding this comment.
| <h2 className="text-2xl font-semibold my-2 text-center text-darkGunMetal hover:underline cursor-pointer">Mentorship Program</h2> | |
| <h2 className="text-2xl font-semibold my-2 text-center text-darkGunMetal">Mentorship Program</h2> |
Hover properties should be applied to Card, not on heading. You can increase shadow while hovering over the Card. Same for all cards.
| <div className="flex flex-col items-center"> | ||
| <img src="/img/illustrations/MentorshipProgram.webp" alt="Mentorship Program" className="w-1/5 h-auto object-cover rounded-md m-1" /> | ||
| <h2 className="text-2xl font-semibold my-2 text-center text-darkGunMetal">Mentorship Program</h2> | ||
| <Link href="https://www.asyncapi.com/blog/beyond-boundaries"> |
There was a problem hiding this comment.
Use a tag nested inside Link to passdown the href and target properties in the Card. You can take reference from here - https://github.com/asyncapi/website/blob/master/components/navigation/BlogPostItem.js#L30-L31. Do it for all Cards.
|
@SwetanshuSingh any update on this one?? |
raising the pr by eod |
There was a problem hiding this comment.
@SwetanshuSingh I checked the preview and it doesnot look good as some components are small and some are large while in previous UI it was aligned
|
|
|
@sambhavgupta0705 I am really sorry for making this silly mistake. I will fix this right now! |
|
We already have PR for #2482 , hence closing this PR. @SwetanshuSingh Kindly work on some other issue to contribute to the project. |
Description
In this pull request, I have made the following changes:
Added navigation links to certain components for improved user navigation. The new links provide direct access to relevant services.
Addressed minor typographical errors throughout the codebase to enhance code readability and maintain consistency.
Related issue(s)
Fixes #2482