-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed the i18n feature for smaller screens #2877
fix: fixed the i18n feature for smaller screens #2877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2877--asyncapi-website.netlify.app/ |
@sambhavgupta0705 I just want to know if this is what we want to achieve. As far as I know, we were to implement the language icon for the selector instead of the default selection drop-down view. |
Sorry I didn't get it |
PTAL @anshgoyalevil |
@sambhavgupta0705 I am referring to this comment #2708 (comment) where I guess we were to use an icon for language selector |
@akkshitgupta Your PR looks good 😄 though, we didn't get any explicit recommendation from @Mayaleeeee about how the Language Selector should look like. In my view, the dropdown should look identical to the current one in contrast to using an "Icon Only" that would not show the currently selected language. I have a few recommendations though. Watch out how it looks on websites (on mobile view) like:
|
hello @anshgoyalevil here is my two cent, I think from a UX point of view, keeping the language selector outside would be more preferable. it would be easier to navigate for the user and keeping it separate from the main content in the dropdown. @Mayaleeeee @derberg what do you guys think?. @anshgoyalevil I can put that in the dropdown if you think it more convenient. 😁 |
closing this as it was opened before migration |
@TenzDelek if you would like to work on this one then you may open a new PR for this and then we can review it |
Fixes #2708
Description