Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the i18n feature for smaller screens #2877

Closed

Conversation

TenzDelek
Copy link
Contributor

Fixes #2708

Description

  • enabled the language button for the smaller screen
  • When Menu is closed:
image - when Menu is open: image
  • also found duplicate py in LanguageSelect file, so removed the py-0 from the file

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a26ac86
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6626820b45558c00082cdd54
😎 Deploy Preview https://deploy-preview-2877--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Apr 17, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 40
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2877--asyncapi-website.netlify.app/

components/navigation/NavBar.js Outdated Show resolved Hide resolved
@akkshitgupta
Copy link
Contributor

@sambhavgupta0705 I just want to know if this is what we want to achieve. As far as I know, we were to implement the language icon for the selector instead of the default selection drop-down view.

@sambhavgupta0705
Copy link
Member

@sambhavgupta0705 I just want to know if this is what we want to achieve. As far as I know, we were to implement the language icon for the selector instead of the default selection drop-down view.

Sorry I didn't get it

@sambhavgupta0705
Copy link
Member

PTAL @anshgoyalevil

@akkshitgupta
Copy link
Contributor

akkshitgupta commented Apr 22, 2024

Sorry I didn't get it

@sambhavgupta0705 I am referring to this comment #2708 (comment) where I guess we were to use an icon for language selector

@anshgoyalevil
Copy link
Member

anshgoyalevil commented Apr 22, 2024

@akkshitgupta Your PR looks good 😄 though, we didn't get any explicit recommendation from @Mayaleeeee about how the Language Selector should look like.

In my view, the dropdown should look identical to the current one in contrast to using an "Icon Only" that would not show the currently selected language.

I have a few recommendations though. Watch out how it looks on websites (on mobile view) like:

@TenzDelek
Copy link
Contributor Author

hello @anshgoyalevil here is my two cent, I think from a UX point of view, keeping the language selector outside would be more preferable. it would be easier to navigate for the user and keeping it separate from the main content in the dropdown. @Mayaleeeee @derberg what do you guys think?. @anshgoyalevil I can put that in the dropdown if you think it more convenient. 😁

@sambhavgupta0705
Copy link
Member

closing this as it was opened before migration

@sambhavgupta0705
Copy link
Member

@TenzDelek if you would like to work on this one then you may open a new PR for this and then we can review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling i18n feature for smaller screens
5 participants