Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of using Montezuma to "replace" filter.lisp #28

Open
guojing0 opened this issue Sep 17, 2022 · 3 comments
Open

Status of using Montezuma to "replace" filter.lisp #28

guojing0 opened this issue Sep 17, 2022 · 3 comments

Comments

@guojing0
Copy link
Contributor

In atlas-engineer/nyxt#1911, it's mentioned by @Ambrevar that

I have hope that Montezuma would advantageously replace all the code in filter.lisp, except for the (mk-string-metrics:norm-damerau-levenshtein suggestion-string input) line since Montezuma does not perform fuzzy-matching.

I just checked and saw that filter.lisp was still there. It's been almost a year, so I was wondering that what's the status of it?

@aartaka
Copy link
Contributor

aartaka commented Sep 17, 2022

In atlas-engineer/nyxt#2536, Pierre said that Montezuma is not a flexible as it should probably be. So I'm not sure it's the right way to go.

@Ambrevar
Copy link
Member

Well, since we are going to depend on it anyways, we could indeed replace the prompter code.
But first we would need some benchmarks with relevance tests.

Not very hard...

@Ambrevar
Copy link
Member

A quick update: Montezuma seems to be too unfinished to be future-proof. Xapian might be a better option, but then we would need to write CL bindings (couldn't find existing ones).

@aadcg aadcg transferred this issue from atlas-engineer/nyxt Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants