-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor userResolvers, models and helpers #416
Open
shema-surge
wants to merge
1
commit into
refactor/develop
Choose a base branch
from
fix/helpers-utils-types
base: refactor/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shema-surge
changed the title
Refactor seeders, model Interfaces and userResolvers
Refactor seeders, model Interfaces, helpers and userResolvers
Nov 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/develop #416 +/- ##
===================================================
Coverage ? 10.04%
===================================================
Files ? 91
Lines ? 3126
Branches ? 730
===================================================
Hits ? 314
Misses ? 2807
Partials ? 5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
shema-surge
requested review from
Salim-54,
ncutixavier,
ceelogre,
MugemaneBertin2001,
jniyonkuru,
Yvan-David and
YvetteNyibuka
November 13, 2024 08:27
shema-surge
force-pushed
the
fix/helpers-utils-types
branch
from
November 13, 2024 08:38
f5d8c40
to
9b0292e
Compare
shema-surge
force-pushed
the
fix/helpers-utils-types
branch
from
November 20, 2024 05:57
9b0292e
to
00e0f7a
Compare
shema-surge
force-pushed
the
fix/helpers-utils-types
branch
from
November 20, 2024 09:10
00e0f7a
to
849ef20
Compare
shema-surge
changed the title
Refactor seeders, model Interfaces, helpers and userResolvers
Refactor userResolvers
Nov 20, 2024
shema-surge
changed the title
Refactor userResolvers
Refactor userResolvers, models and helpers
Nov 20, 2024
Yvan-David
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR refactors seeers, some helpers, model types, models and userResolver mutations and queries
completed task.
Functionality
Seeders, models and userResolvers were refactored to reflect the new ERD https://lucid.app/lucidchart/1eee122d-6b91-47bf-b195-1975068f307a/edit?viewport_loc=-1649%2C445%2C2406%2C1184%2C0_0&invitationId=inv_5dd51ee1-2e33-424e-9676-babe99b3e5c6
How has this been tested?
These fixes were tested in Apollo Sandbox
PR Checklist:
Track PR
Trello Link (#DP-?)
Screenshots (If appropriate)
(Images)