Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor userResolvers, models and helpers #416

Open
wants to merge 1 commit into
base: refactor/develop
Choose a base branch
from

Conversation

shema-surge
Copy link
Contributor

@shema-surge shema-surge commented Nov 7, 2024

PR Description

This PR refactors seeers, some helpers, model types, models and userResolver mutations and queries
completed task.

Functionality

Seeders, models and userResolvers were refactored to reflect the new ERD https://lucid.app/lucidchart/1eee122d-6b91-47bf-b195-1975068f307a/edit?viewport_loc=-1649%2C445%2C2406%2C1184%2C0_0&invitationId=inv_5dd51ee1-2e33-424e-9676-babe99b3e5c6

How has this been tested?

These fixes were tested in Apollo Sandbox

PR Checklist:

  • Task 1. Refactor Seeders
  • Task 2. Refactor helpers
  • Task 3. Refactor models
  • Task n. Refactor userResolvers.ts

Track PR

Trello Link (#DP-?)

Screenshots (If appropriate)

(Images)

@shema-surge shema-surge changed the title Refactor seeders, model Interfaces and userResolvers Refactor seeders, model Interfaces, helpers and userResolvers Nov 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 14.97976% with 420 lines in your changes missing coverage. Please review.

Please upload report for BASE (refactor/develop@c2f70ca). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/userResolver.ts 2.92% 299 Missing ⚠️
src/helpers/user.helpers.ts 16.00% 63 Missing ⚠️
src/models/organization.model.ts 50.00% 14 Missing ⚠️
src/validations/index.ts 33.33% 12 Missing ⚠️
src/utils/notification/pushNotification.ts 25.00% 9 Missing ⚠️
src/utils/cron-jobs/team-jobs.ts 0.00% 7 Missing ⚠️
src/helpers/organization.helper.ts 25.00% 6 Missing ⚠️
src/models/user.ts 68.75% 5 Missing ⚠️
src/utils/templates/suspiciousActivityTemplate.ts 40.00% 3 Missing ⚠️
src/plugins/mongooseSoftDelete.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             refactor/develop     #416   +/-   ##
===================================================
  Coverage                    ?   10.04%           
===================================================
  Files                       ?       91           
  Lines                       ?     3126           
  Branches                    ?      730           
===================================================
  Hits                        ?      314           
  Misses                      ?     2807           
  Partials                    ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ncutixavier ncutixavier changed the base branch from develop to refactor/develop November 8, 2024 11:45
@shema-surge shema-surge changed the title Refactor seeders, model Interfaces, helpers and userResolvers Refactor userResolvers Nov 20, 2024
@shema-surge shema-surge changed the title Refactor userResolvers Refactor userResolvers, models and helpers Nov 20, 2024
@Salim-54 Salim-54 added WIP Work in progress and removed WIP Work in progress labels Nov 22, 2024
@Salim-54 Salim-54 added Needs Reviews A pull request need reviews to be merged Refactor labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Reviews A pull request need reviews to be merged Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants