Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

atom-text-editor[mini] didn't get correct font size #407

Open
btstw opened this issue May 19, 2017 · 2 comments
Open

atom-text-editor[mini] didn't get correct font size #407

btstw opened this issue May 19, 2017 · 2 comments
Assignees
Labels

Comments

@btstw
Copy link

btstw commented May 19, 2017

font size are smaller than setting

Reproduction Steps:

  1. Update this package.
  2. I notice font size in search bar become smaller than previous version, try go to setting to fix it.
  3. When disable this theme font size setting are fine.

Expected behavior:

font size should correct in search bar

Observed behavior:

font size are setting to 12

Screenshots and GIFs

screenhunter_02 may 19 16 27
screenhunter_01 may 19 16 23

Atom version: 1.17.0
OS and version: Win7

Installed packages:

Atom material UI and syntax theme

@silvestreh silvestreh self-assigned this May 22, 2017
@silvestreh silvestreh added the bug label May 22, 2017
@silvestreh
Copy link
Member

silvestreh commented May 22, 2017

Good catch, but you won't get the exact same size.

This feature should probably be renamed because it affects the entire UI, not just text. Buttons, for example, aren't being correctly resized for the same reason: they are using fixed UI variables (@component-line-height and @component-padding) instead of being based off of this value.

@ryanaltvater
Copy link

ryanaltvater commented Aug 10, 2017

@silvestreh I can confirm on Windows that this setting does not do anything. When I disable the theme, my UI font sizes are fine. When it's enabled, all UI fonts are roughly 12px and almost unreadable. I do not have this problem on my MacBook.

Atom version: 1.19.0
Atom Material UI version: 2.0.4
OS version: Windows 10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants