Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

Primary and Secondary colors are ignored in 2.1.2 #463

Open
nemchik opened this issue Feb 15, 2018 · 24 comments
Open

Primary and Secondary colors are ignored in 2.1.2 #463

nemchik opened this issue Feb 15, 2018 · 24 comments

Comments

@nemchik
Copy link

nemchik commented Feb 15, 2018

I just upgraded to 2.1.2 and have found that my selected Primary and Secondary colors are no longer applied.

Reproduction Steps:

  1. Have a Primary and Secondary color set

Expected behavior:

The UI should use my Primary and Secondary selected colors.

Observed behavior:

The UI uses the default teal color

Screenshots and GIFs

Screenshots and GIFs which follow reproduction steps to demonstrate the problem

Atom version: 1.24.0 x64
OS and version: Microsoft Windows [Version 10.0.16299.248]

Installed packages:

Community Packages (36) .atom\packages
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

@nemchik
Copy link
Author

nemchik commented Feb 15, 2018

P.S. This was not an issue on the previous version prior to updating to 2.1.2 and I have tried completely closing Atom (and ensuring no atom.exe tasks remain) and then reopening and the issue persists.

@silvestreh
Copy link
Member

have you tried setting your custom color again?

@nemchik
Copy link
Author

nemchik commented Feb 15, 2018

Yes I have tried changing to other colors and then setting back to my preferred colors and this hasn't resolved it. I also tried the predefined color selection select list and none of them seem to work either.

@madeddy
Copy link

madeddy commented Feb 15, 2018

Have the same:

d3629c5

@entepe85
Copy link

I'm experiencing the same issue. I somehow managed to set a different color while using the Material Light Syntax theme but after changing that I am unable to change the default color.

@kfalkiewicz
Copy link

Got same issue. Tried changing colors, as set, or individually. Nothing changes.

@MxRay
Copy link

MxRay commented Feb 16, 2018

I can confirm same issue too. Tried everything, changing pre-defined colors, custom colors and nothing works.

Correction: everything works after I restarted my PC.

@xeho91
Copy link

xeho91 commented Feb 16, 2018

I can confirm that after computer restart it works.
Using Windows 10 Pro N (64x).

@gregtyler
Copy link

gregtyler commented Feb 16, 2018

This was fixed for me by just restarting Atom, not the whole PC.

Edit: I think I switched to another pre-defined colour, then back to the one I wanted before restarting Atom. Comments below would suggest that doing so works more consistently.

@silvestreh
Copy link
Member

silvestreh commented Feb 16, 2018

I wasn't able to reproduce this one. But looks like the solution was to restart Atom (or your computer), so I'm thinking it might've been cache related? 😕

On the upside, I did find another bug introduced in 2.1.2 which rendreded the accent color generator useless. Just pushed 2.1.3

@nemchik
Copy link
Author

nemchik commented Feb 16, 2018

I have both rebooted my PC and restarted Atom (as mentioned in my initial post and comments) and the issue persists for me. Is there something special I have to do in order to clear cache for Atom?

@nemchik
Copy link
Author

nemchik commented Feb 16, 2018

Ok, I closed and reopened Atom again just now and the colors started working. Then I was prompted to update to 2.1.3 and I did this and was prompted to restart Atom. After restarting Atom the colors stopped working. I restarted again and the colors started working again. This is pretty irritating behavior.

@PeteCrighton
Copy link

Can confirm, happened to me after both updates to 2.1.2 & 2.1.3. Simply restarting Atom didn’t fix it, but choosing another predefined color and switching back to the desired color again, then restarting Atom fixed it for me.

@phlippieb
Copy link

Same issue on MacOS. I can't find a workaround. Have tried to

  1. Select custom colours again
  2. Select predefined colours, then do 1 (the UI doesn't even update to the selected predefined colours)
  3. Restart atom, then do 2, then 1
  4. Restart PC, then 2, then 1

@DominikZians
Copy link

I got the same issue (MacOS, Atom 1.24.0), but only in combination with the atom-material-syntax. When I choose an other syntax (for ex. atom-material-syntax-dark) the color changes to the choosen primary color. Changing back to the atom-material-syntax changes the color back to default.

@drakesong
Copy link

drakesong commented Feb 23, 2018

Have the same issue. This problem only occurs when atom-material-ui and atom-material-syntax are selected. Having any other syntax theme such as atom-material-syntax-dark does not reproduce the problem.

Versions

  • Atom 1.24.0
  • atom-material-ui 2.1.3
  • atom-material-syntax 1.0.8

Tried

  • Restarting Atom
  • Restarting PC
  • Resetting config for atom-material-ui

@tumido
Copy link

tumido commented Feb 23, 2018

Despite not using atom-material-syntax, I can also confirm this issue. I'm using material-design-syntax. Changing to some other-and-not-affected syntax themes workaround this issue. The stock ones like Base16, One, Solarized works fine as well.

@nemchik
Copy link
Author

nemchik commented Feb 23, 2018

I should note that I use Base16 Tomorrow Dark syntax and the issue of updates causing the colors to not work until a restart of Atom has been around for a LONG time before I opened this ticket. Prior to version 2.1.2 I was able to simply able to restart Atom one extra time after an update and the colors would start working again. 2.1.2 changed that and I was unable to get the colors to set correctly again until 2.1.3 showed up as available (see my comments above).

@micleb
Copy link

micleb commented Mar 1, 2018

Same issue, my atom-material-ui is in 1.2.3

@ghost
Copy link

ghost commented Mar 6, 2018

For me this issue occurs right now on specific syntax themes (like Atom Snazzy Clear). On standard one everything looks fine.

PS: No errors in dev console.

@biogeo
Copy link

biogeo commented Apr 17, 2018

Same issue here with Atom 1.19.1, atom-material-ui 2.1.3 running on Ubuntu Linux. Using syntax theme Gruvbox Plus causes the color settings to be ignored; other syntax themes, including atom-material-syntax, work normally.

@fragmential
Copy link

same issue here, I'm on macOS 10.14.4, Atom 1.36.0 x64 and atom-material-ui 2.1.3. It doesn't seem to matter which syntax theme is in use. I've restarted Atom and uninstalled and reinstalled atom-material-ui and the issue still persists. Predefined colors are also ignored. I don't really like the teal so this is quite a problem for me.

@evelynhathaway

This comment has been minimized.

@shincap8
Copy link

shincap8 commented Jun 2, 2021

@evelynhathaway You're right, and I already solved it, I was importing ThemeProvider from the wrong library 😅. But thank you so much for taking the time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests