This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Issues #178 and #174 . "Symbol not found" due to 1) issue with escape char in tag 2) default ctags missing ES2015-style function definition #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not just leading and trailing regex chars must be removed. Ex: /^
myFunction() { \/\/ a comment $/
Fix for fat arrow functions and declarations starting with ‘const’.
dperetti
changed the title
The bundled ctags binary is configured to search for javascript “properties”, yielding bogus results. Fixes atom#180 .
Add static properties to matching symbols, as they are usually quite important.
Again, ctags defaults yield bogus results in javascript. Disabling default “function” type for tag search, as the regex provided in ctags-config do the job better. Fixes atom#166
|
Hmm ok if we disable ctags default function search for javascript we get this : ... instead of this ...
... and the test doesn't pass. But if we keep using it we have more important issues (bogus results). Any thought ? |
|
Any updates on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not just leading and trailing regex chars must be removed. Ex: /^
myFunction() { // a comment $/
Fixes : #178
Make default ctags file more ES2015 friendly.
Fixes #174