Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APKAM - client side changes for authenticate using apkam keypair #1078

Closed
Tracked by #29
murali-shris opened this issue Jun 26, 2023 · 9 comments
Closed
Tracked by #29

APKAM - client side changes for authenticate using apkam keypair #1078

murali-shris opened this issue Jun 26, 2023 · 9 comments
Assignees
@murali-shris
Labels
enhancement New feature or request

Comments

@murali-shris
Copy link
Member

murali-shris commented Jun 26, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

https://github.com/atsign-foundation/at_protocol/blob/trunk/decisions/2023-01-pkam-per-app-and-device.md

Describe the solution you'd like

  • changes while creating atchops instance to set apkam keypair
  • changes to places where auth is done to remote secondary using apkam keypair
  • any other client side changes based on the apkam spec

Describe alternatives you've considered

No response

Additional context

No response
@murali-shris murali-shris added the enhancement New feature or request label Jun 26, 2023
@murali-shris murali-shris self-assigned this Jun 26, 2023
@XavierChanth XavierChanth mentioned this issue Jun 29, 2023
Open
@murali-shris
Copy link
Member Author

Did not start in PR65, Will complete onboarding_cli changes and take this up.

@murali-shris
Copy link
Member Author

onboarding_cli changes still in progress.carrying over

@murali-shris
Copy link
Member Author

onboarding_cli changes still in progress.carrying over

No progress in PR67

@murali-shris
Copy link
Member Author

murali-shris commented Aug 21, 2023 •
edited
Loading

Carrying over to PR69. Have to start with changes in at_client_mobile

@murali-shris
Copy link
Member Author

at_client_mobile changes in progress.
https://github.com/atsign-foundation/at_client_sdk/tree/apkam_onboarding_changes

@murali-shris
Copy link
Member Author

murali-shris commented Sep 18, 2023 •
edited
Loading

changes done in PR70

  • onboarding implementation in at_client_mobile done.
  • changes in at_onboarding_flutter to use new impl in at_client_mobile
  • onboarding test. atKeys file is not getting generated. Have to fix this bug
  • pending impl - authenticate and enroll methods in at_client_mobile
  • adding 8SP for pending work, 5SP for testing and bug fixing

@murali-shris
Copy link
Member Author

murali-shris commented Oct 3, 2023 •
edited by sitaram-kalluri
Loading

changes done in PR71

  • completed authenticate and enroll impl in at_client_mobile
  • worked on documentation and discussion on package restructuring and removing code duplication
  • fixed the bug to generate atKeys file
  • Fixed bugs in authentication and onboarding flow
  • Populate "enrollmentId" to notification_service_impl and atClient instance for authentication

@murali-shris
Copy link
Member Author

murali-shris commented Oct 3, 2023 •
edited
Loading

pending

  • replace the duplicate code with at_auth package once the package is ready
  • testing

@murali-shris
Copy link
Member Author

Closing this task and creating specific tasks for pending client side changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@murali-shris murali-shris

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@murali-shris