Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement notify in Java SDK #6

Open
VJag opened this issue May 16, 2022 · 8 comments · May be fixed by #63
Open

Implement notify in Java SDK #6

VJag opened this issue May 16, 2022 · 8 comments · May be fixed by #63
Labels
5 SP 5 Story Points - 3 Days Medium

Comments

@VJag
Copy link
Member

VJag commented May 16, 2022

Implement the ability to notify and get status if a notification in Java SDK

@VJag VJag self-assigned this May 16, 2022
@VJag VJag added the 5 SP 5 Story Points - 3 Days Medium label May 16, 2022
@ksanty ksanty added PR37 May 2022 Sprint Planning and removed PR37 May 2022 Sprint Planning labels May 17, 2022
@gkc
Copy link
Contributor

gkc commented May 31, 2022

Some progress in PR37 by @VJag

@VJag
Copy link
Member Author

VJag commented May 31, 2022

Code for this task is available in the branch "at_java_sdk_picocli_expermient" however I am changing the implementation by implementing reusable code for all of the common functionalities like "encryption", "decryption", "request and response transformers". This common code is available in the branch "at_java_sdk_with_scan_and_notify". So I will be moving the notify code into "at_java_sdk_with_scan_and_notify" when I start on this.

@JeremyTubongbanua
Copy link
Member

I can take this on

@gkc
Copy link
Contributor

gkc commented Jul 25, 2022

Great!

@ksanty
Copy link
Member

ksanty commented Jul 29, 2022

@JeremyTubongbanua are you currently working on this? I know your internship is over.

@JeremyTubongbanua
Copy link
Member

I am not currently at the moment.
I meant to start working on it a few days ago but never got the chance

@gkc
Copy link
Contributor

gkc commented Sep 23, 2022

Hey @JeremyTubongbanua - just wanted to mention that with all of the recent enhancements and performance and scalability enhancements related to notifications in the at_server and in the Dart client, this would be a really good time to do the notify client implementation for the Java client. So ... next time you are looking for the next piece of code to write, please think about this!

@JeremyTubongbanua
Copy link
Member

Hey @JeremyTubongbanua - just wanted to mention that with all of the recent enhancements and performance and scalability enhancements related to notifications in the at_server and in the Dart client, this would be a really good time to do the notify client implementation for the Java client. So ... next time you are looking for the next piece of code to write, please think about this!

Acknowledged. Thanks Gary

@JeremyTubongbanua JeremyTubongbanua linked a pull request Oct 12, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 SP 5 Story Points - 3 Days Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants