Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at_commons: Deprecate the obsolete "isHidden" attribute from Metadata #524

Open
gkc opened this issue Feb 24, 2024 · 0 comments
Open

at_commons: Deprecate the obsolete "isHidden" attribute from Metadata #524

gkc opened this issue Feb 24, 2024 · 0 comments
Assignees

Comments

@gkc
Copy link
Contributor

gkc commented Feb 24, 2024

Is your feature request related to a problem? Please describe.

"isHidden" should be removed from metadata; the "hidden" semantic is achieved only by convention in the atServer and in the atClient's LocalSecondary, by prefixing a key with 1 or 2 underscores as per example below. isHidden is neither stored nor referenced by the atServer, nor by the atClient's LocalSecondary

  • // public hidden key: public:__location@alice 
    
  • // self hidden key: _location@alice
    

Describe the solution you'd like

Mark isHidden as Deprecated in at_commons metadata. Remove references to isHidden from all packages which depend on at_commons - I have found references in at_client, at_lookup and at_login_flutter but there may be more. Note that there is actually code in AtLookupImpl's update method which silently prefixes an underscore if isHidden is set to true; we need to check if any app or example or widget uses this feature

@gkc gkc added the Tech Debt label Feb 24, 2024
@gkc gkc changed the title Remove obsolete "isHidden" attribute from metadata at_commons: Remove obsolete "isHidden" attribute from Metadata Feb 24, 2024
@gkc gkc changed the title at_commons: Remove obsolete "isHidden" attribute from Metadata at_commons: Deprecate the obsolete "isHidden" attribute from Metadata Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants