Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uptake websocket in place of a socket in atLookup #667

Open
purnimavenkatasubbu opened this issue Sep 23, 2024 · 6 comments
Open

uptake websocket in place of a socket in atLookup #667

purnimavenkatasubbu opened this issue Sep 23, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@purnimavenkatasubbu
Copy link
Member

purnimavenkatasubbu commented Sep 23, 2024

Is your feature request related to a problem? Please describe.

To improve performance

Describe the solution you'd like

To enhance the communication mechanism by using a WebSocket-based connection

Describe alternatives you've considered

No response

Additional context

No response

@gkc
Copy link
Contributor

gkc commented Sep 23, 2024

Note we don't want to replace, but to enhance by providing the option when using AtLookup to create and use websocket connections rather than plain socket connections

@purnimavenkatasubbu
Copy link
Member Author

purnimavenkatasubbu commented Oct 14, 2024

Changes can be found in the ws_version2

The current issue is that the client closes the WebSocket connection prematurely, without waiting for the server's response. Need to find the root cause for the same.

The same code changes work fine when implemented with Python, but in the Dart implementation (branch [us_Version2]), the client closes the WebSocket connection prematurely, without waiting for the server's response.
https://gist.github.com/purnimavenkatasubbu/31bc98d9c4460a53372ae5bbb89f8e13

@purnimavenkatasubbu
Copy link
Member Author

A working version has been pushed to the branch ws_version.

We are currently working on optimizing the design and have documented three potential approaches in detail
Approaches

@purnimavenkatasubbu
Copy link
Member Author

A new approach has been implemented and changes are pushed to the branch ws_approach1

@purnimavenkatasubbu
Copy link
Member Author

changes are done and PR is ready for review #709

@purnimavenkatasubbu
Copy link
Member Author

Had a call with @gkc , during which Gary suggested refactoring the code by completely removing the outbound connection-related classes and their implementations. I’ve already made the changes and will be raising a new PR to reflect them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants