feat: added WebSocket support in AtLookup #709

purnimavenkatasubbu · 2024-11-13T21:49:59Z

- What I did
Implemented WebSocket support by introducing a new connection factory structure to support both SecureSocket and WebSocket connections. This update allows AtLookupImpl to dynamically choose between secure socket and WebSocket connections, enhancing flexibility and enabling WebSocket-based communication when required.

- How I did it

Created a new abstract factory class, AtLookupOutboundConnectionFactory, to standardize the creation of underlying connections, outbound connection wrappers, and message listeners for different connection types.
Developed AtLookupSecureSocketFactory and AtLookupWebSocketFactory to handle secure socket and WebSocket connections, respectively. Each factory is responsible for:
- Establishing the underlying connection (either SecureSocket or WebSocket).
- Wrapping the connection into an outbound connection instance (OutboundConnectionImpl or OutboundWebsocketConnectionImpl).

- How to verify it

Existing tests for SecureSocket connections should continue working as expected.
Added functional tests by passing the AtLookupWebSocketFactory should pass

- Description for the changelog

add WebSocket support in AtLookupImpl

…ries into ws_version2

…ries into ws_approach1

… after the connection time-outs.

murali-shris · 2024-11-21T12:02:38Z

packages/at_lookup/lib/src/at_lookup_impl.dart

@@ -240,22 +243,24 @@ class AtLookupImpl implements AtLookUp {

  Future<void> createConnection() async {
    if (!isConnectionAvailable()) {
-      if (_connection != null) {
+      if (connection != null) {


I see connection and _connection both..can we use just _connection while referring the var inside AtLookUpImpl

Updated be8058b

murali-shris · 2024-11-21T13:48:48Z

packages/at_lookup/lib/at_lookup.dart

@@ -6,9 +6,12 @@ library at_lookup;
 export 'src/at_lookup.dart';
 export 'src/at_lookup_impl.dart';
 export 'src/connection/outbound_connection.dart';
+export 'src/connection/outbound_websocket_connection.dart';
 export 'src/connection/outbound_connection_impl.dart';
 export 'src/exception/at_lookup_exception.dart';
 export 'src/monitor_client.dart';
 export 'src/cache/secondary_address_finder.dart';


since we have modified SecondaryUrlFinder constructor and exported this class, the change should be treated as breaking and have a major release

Updated be8058b

murali-shris · 2024-11-21T14:04:02Z

packages/at_lookup/lib/src/at_lookup_impl.dart

+          .atLookupSocketListenerFactory(outboundConnection);
+
+      // Set the connection type in `_webSocketConnection` or `_connection`
+      if (underlying is WebSocket) {


this type casting has no impact on the code since we are not accessing any attributes specific to OutboundWebSocketConnection or OutboundConnection
If _connection is not set before, we can just have
_connection = outboundConnection

Updated [be8058b]

…ries into ws_approach1

sitaram-kalluri · 2024-11-23T01:57:50Z

packages/at_lookup/lib/at_lookup.dart

 export 'src/connection/outbound_connection_impl.dart';
 export 'src/exception/at_lookup_exception.dart';
 export 'src/monitor_client.dart';
 export 'src/cache/secondary_address_finder.dart';
 export 'src/cache/cacheable_secondary_address_finder.dart';
 export 'src/util/secure_socket_util.dart';
+export 'src/connection/outbound_websocket_connection_impl.dart';


Please avoid exporting the implementation classes.

sitaram-kalluri · 2024-11-25T03:04:16Z

packages/at_lookup/lib/at_lookup.dart

 export 'src/connection/outbound_connection_impl.dart';
 export 'src/exception/at_lookup_exception.dart';
 export 'src/monitor_client.dart';
 export 'src/cache/secondary_address_finder.dart';
 export 'src/cache/cacheable_secondary_address_finder.dart';
 export 'src/util/secure_socket_util.dart';
+// export 'src/connection/outbound_websocket_connection_impl.dart';


I suggest removing the line instead of commenting it out.

Sorry, My Bad!! Removed commented line

murali-shris · 2024-11-29T10:36:08Z

packages/at_lookup/lib/src/at_lookup_impl.dart

@@ -661,7 +684,7 @@ class AtLookupImpl implements AtLookUp {
  Future<void> _sendCommand(String command) async {
    await createConnection();
    logger.finer('SENDING: $command');
-    await _connection!.write(command);
+    _connection!.write(command);


await is removed here?

I think await is needed

I verified the code and "write" operation on the socket does not return a future. Hence suggested to remove await.

murali-shris · 2024-11-29T10:46:06Z

packages/at_lookup/lib/src/util/secure_socket_util.dart

+        serverSide: false,
+      );
+
+      print('WebSocket connection established');


remove this print and replace with logger

purnimavenkatasubbu · 2024-12-09T19:03:48Z

Opened a new PR with the refactored code. Hence closing this PR

purnimavenkatasubbu and others added 20 commits September 27, 2024 01:38

changed version of websocket

b586311

websocket changes

caa7591

Merge remote-tracking branch 'origin/trunk' into ws_version2

ffc02f5

fixed closing ws connection

63fc299

changes

df4658d

Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…

ab88f5e

…ries into ws_version2

Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…

d88a139

…ries into ws_version2

refactored code

417234c

Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…

0eca375

…ries into ws_version2

refactored code based on factories

b78716a

removed commented code

3f453af

Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…

0452d85

…ries into ws_approach1

addressed review comments

a72cf1a

updated unit tests

a7c8e64

fixed failing test

aee94bb

fix: Updated mock references to prevent null pointer errors

a67171b

fix: Add unit test - A test to verify the connections are invalidated…

49b840b

… after the connection time-outs.

fixed failing unit test

4f23462

pubspec

95fc90c

correct atsign and removed commented code

a635041

purnimavenkatasubbu marked this pull request as ready for review November 14, 2024 12:52

purnimavenkatasubbu requested a review from VJag November 14, 2024 12:53

purnimavenkatasubbu added 3 commits November 18, 2024 22:01

removed useWebSocket flag and added unit tests

65f6141

renamed variables and minor changes

61e2913

addressed review comments

b4eef12

purnimavenkatasubbu requested review from sitaram-kalluri and murali-shris November 19, 2024 16:06

murali-shris requested changes Nov 21, 2024

View reviewed changes

purnimavenkatasubbu added 2 commits November 22, 2024 03:31

Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…

ab72ec6

…ries into ws_approach1

addressed review commits

be8058b

purnimavenkatasubbu requested a review from murali-shris November 21, 2024 22:14

removed commented code

b32009b

sitaram-kalluri reviewed Nov 23, 2024

View reviewed changes

review comments

9ea9415

purnimavenkatasubbu requested a review from sitaram-kalluri November 25, 2024 02:52

sitaram-kalluri reviewed Nov 25, 2024

View reviewed changes

removed commented code

5dc5a47

purnimavenkatasubbu requested a review from sitaram-kalluri November 25, 2024 03:55

purnimavenkatasubbu mentioned this pull request Nov 25, 2024

uptake websocket in place of a socket in atLookup #667

Open

murali-shris requested changes Nov 29, 2024

View reviewed changes

purnimavenkatasubbu added 2 commits December 4, 2024 20:37

addressed more review comments

3e05187

changing heirarchy and removeing outboundconnection

8e5aaee

purnimavenkatasubbu closed this Dec 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added WebSocket support in AtLookup #709

feat: added WebSocket support in AtLookup #709

purnimavenkatasubbu commented Nov 13, 2024 •

edited

Loading

murali-shris Nov 21, 2024

purnimavenkatasubbu Nov 21, 2024 •

edited

Loading

murali-shris Nov 21, 2024

purnimavenkatasubbu Nov 21, 2024 •

edited

Loading

murali-shris Nov 21, 2024

purnimavenkatasubbu Nov 21, 2024 •

edited

Loading

sitaram-kalluri Nov 23, 2024

purnimavenkatasubbu Nov 25, 2024

sitaram-kalluri Nov 25, 2024

purnimavenkatasubbu Nov 25, 2024

murali-shris Nov 29, 2024

VJag Nov 29, 2024

sitaram-kalluri Dec 8, 2024

murali-shris Nov 29, 2024

purnimavenkatasubbu commented Dec 9, 2024

feat: added WebSocket support in AtLookup #709

feat: added WebSocket support in AtLookup #709

Conversation

purnimavenkatasubbu commented Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

purnimavenkatasubbu Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

purnimavenkatasubbu Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

purnimavenkatasubbu Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

purnimavenkatasubbu commented Dec 9, 2024

purnimavenkatasubbu commented Nov 13, 2024 •

edited

Loading

purnimavenkatasubbu Nov 21, 2024 •

edited

Loading

purnimavenkatasubbu Nov 21, 2024 •

edited

Loading

purnimavenkatasubbu Nov 21, 2024 •

edited

Loading