feat: Added a new toast #476
Open
+238
−4,508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #474 from atsign-foundation/toast_in_commons
nitesh2599
reviewed
Aug 23, 2022
nitesh2599
reviewed
Aug 23, 2022
| bool isSuccess = false}) { | ||
| assert(!(isError && isSuccess), 'Both isError and isSuccess cannot be true'); | ||
| assert(gravity >= 0, 'gravity cannot be less than 0'); | ||
| ScaffoldMessenger.of(context).showSnackBar( |
There was a problem hiding this comment.
@yahu1031 we also have to assert that the given context has a ScaffoldMessenger ancestor.
nitesh2599
reviewed
Aug 23, 2022
| text, | ||
| context, | ||
| duration: FlutterToastr.lengthLong, | ||
| /// pass [isError] true to have a red bg, [isSuccess] true to have a green bg. |
There was a problem hiding this comment.
@yahu1031 I think we need not add this class in all the packages, it can be reused from at_commons_flutter.
There was a problem hiding this comment.
yes but we haven't released the package yet
nitesh2599
reviewed
Aug 23, 2022
| double gravity = 10.0, | ||
| bool isError = false, | ||
| bool isSuccess = false}) { | ||
| assert(!(isError && isSuccess), 'Both isError and isSuccess cannot be true'); |
There was a problem hiding this comment.
@yahu1031 I think we can have a dismissDirection property as well.
nitesh2599
reviewed
Aug 23, 2022
| textColor: textColor ?? Colors.white, | ||
| fontSize: 16.0); | ||
| } | ||
| void show(String message, BuildContext context, |
There was a problem hiding this comment.
can be reused from at_commons_flutter.
nitesh2599
reviewed
Aug 23, 2022
| textColor: textColor ?? Colors.white, | ||
| fontSize: 16.0); | ||
| } | ||
| void show(String message, BuildContext context, |
There was a problem hiding this comment.
can be reused from at_commons_flutter.
nitesh2599
reviewed
Aug 23, 2022
| fontSize: 16.0); | ||
| } | ||
| /// pass [isError] true to have a red bg, [isSuccess] true to have a green bg. | ||
| void show(String message, BuildContext context, |
There was a problem hiding this comment.
can be reused from at_commons_flutter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added a custom toast file