fix: atSign activation #948
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierChanth
requested review from
gkc,
sitaram-kalluri,
murali-shris and
CurtlyCritchlow
XavierChanth
commented
Nov 26, 2024
| atSignStatus == ServerStatus.teapot) { | ||
| _onboardingService.setAtsign = previousAtsign; | ||
| } | ||
|
|
There was a problem hiding this comment.
Actual change for this file is here, the rest is formatting from 120 to 80, as this is a published package. (559 old file : 604 new file)
XavierChanth
commented
Nov 26, 2024
Comment on lines
-222
to
+228
| authResponse = await _onboardingService.authenticate(atsign, | ||
| cramSecret: secret, status: OnboardingStatus.ACTIVATE); | ||
| String? previousAtsign = _onboardingService.currentAtsign; | ||
| _onboardingService.setAtsign = atsign; | ||
| authResponse = await _onboardingService.onboard( | ||
| cramSecret: secret, | ||
| ); |
XavierChanth
commented
Nov 26, 2024
Comment on lines
+243
to
+247
| if (authResponse != AtOnboardingResponseStatus.authSuccess || | ||
| atSignStatus == ServerStatus.teapot) { | ||
| _onboardingService.setAtsign = previousAtsign; | ||
| } | ||
|
|
There was a problem hiding this comment.
revert to previous atsign on a failed activation (authSuccess + teapot at this point is considered a timeout failure)
XavierChanth
commented
Nov 26, 2024
Comment on lines
-477
to
+482
| authResponse = await _onboardingService.authenticate( | ||
| verifiedAtSign, | ||
| cramSecret: cramSecret, | ||
| status: OnboardingStatus.ACTIVATE, | ||
| String? previousAtsign = _onboardingService.currentAtsign; | ||
| _onboardingService.setAtsign = verifiedAtSign; | ||
| authResponse = await _onboardingService.onboard( | ||
| cramSecret: secret, | ||
| ); | ||
|
|
XavierChanth
commented
Nov 26, 2024
Comment on lines
-497
to
+502
| } else if (authResponse == AtOnboardingResponseStatus.serverNotReached) { | ||
| } else { | ||
| _onboardingService.setAtsign = previousAtsign; | ||
| } | ||
|
|
||
| if (authResponse == AtOnboardingResponseStatus.serverNotReached) { |
There was a problem hiding this comment.
Same as revert above, slightly different semantic structure in this part of the code, so the change looks different
XavierChanth
commented
Nov 26, 2024
| await _showAlertDialog( | ||
| AtOnboardingLocalizations.current.msg_atSign_unreachable, | ||
| ); | ||
| } else if (authResponse == AtOnboardingResponseStatus.authFailed) { | ||
| await _showAlertDialog( | ||
| AtOnboardingLocalizations.current.error_authenticated_failed, | ||
| ); | ||
| } else { | ||
| } else if (authResponse != AtOnboardingResponseStatus.authSuccess) { |
There was a problem hiding this comment.
breaking the if-else chain requires an explicit check for non-success on our catch-all error check
XavierChanth
commented
Nov 26, 2024
Comment on lines
-85
to
+88
| final String _incorrectKeyFile = AtOnboardingLocalizations.current.msg_cannot_fetch_keys_from_chosen_file; | ||
| final String _failedFileProcessing = AtOnboardingLocalizations.current.error_processing_files; | ||
| final String _incorrectKeyFile = | ||
| AtOnboardingLocalizations.current.msg_cannot_fetch_keys_from_chosen_file; | ||
| final String _failedFileProcessing = | ||
| AtOnboardingLocalizations.current.error_processing_files; |
There was a problem hiding this comment.
This file was misformatted, corrected from 120 to 80, I've marked the actual changes with a comment near line 600
gkc
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Oops spoke too soon ... one of the 'stable' checks is failing https://github.com/atsign-foundation/at_widgets/actions/runs/12036898481/job/33559158729?pr=948
Analyzing at_onboarding_flutter...
warning • Unused import: 'package:at_auth/at_auth.dart' • lib/screen/at_onboarding_activate_screen.dart:4:8 • unused_import
warning • Unused import: 'package:at_client_mobile/at_client_mobile.dart' • lib/screen/at_onboarding_activate_screen.dart:5:8 • unused_import
warning • The value of the local variable 'cramSecret' isn't used • lib/screen/at_onboarding_generate_screen.dart:458:12 • unused_local_variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
fix: atSign activation