Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sshnpd policy handling for ssh_request #1558

Open
gkc opened this issue Nov 19, 2024 · 1 comment
Open

sshnpd policy handling for ssh_request #1558

gkc opened this issue Nov 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@gkc
Copy link
Contributor

gkc commented Nov 19, 2024

Describe the bug

sshnpd allows ssh_request if there is any policy match for the client atSign with the daemon's atSign and device name

Steps to reproduce

  • configure a policy with permitOpen "localhost:12345"
  • attempt an npt request to port 22 - it will fail
  • attempt an ssh_request - it will succeed

Expected behavior

policy decision should be made in the same way for both npt_request and ssh_request

Screenshots

No response

Smartphones

No response

Were you using an atApplication when the bug was found?

No response

Additional context

reported by @cconstab

@gkc gkc added the bug Something isn't working label Nov 19, 2024
@gkc gkc self-assigned this Nov 19, 2024
@gkc
Copy link
Contributor Author

gkc commented Nov 19, 2024

@cconstab looking at the code it looks like this has already been fixed by this PR - can you retest with sshnpd from a recent alpha release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant