We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence ID and command status (the last two parameters) are flipped:
aecp_controller_state_machine.cpp:
log_imp_ref->post_log_msg(LOGGING_LEVEL_ERROR, "RESPONSE_RECEIVED, 0x%llx, %s, %s, %d, %d, %s", jdksavdecc_uint64_get(&id, 0), utility::aem_cmd_value_to_name(cmd_type), utility::aem_desc_value_to_name(desc_type), desc_index, jdksavdecc_aecpdu_common_get_sequence_id(frame, ETHER_HDR_SIZE), utility::aem_cmd_status_value_to_name(status));
acmp_controller_state_machine.cpp:
log_imp_ref->post_log_msg(LOGGING_LEVEL_ERROR, "RESPONSE_RECEIVED, 0x%llx, %s, %s, %s, %s, %d", end_station_entity_id, utility::acmp_cmd_value_to_name(msg_type), "NULL", "NULL", utility::acmp_cmd_status_value_to_name(status), seq_id);
An application that parses "RESPONSE_RECEIVED" type log messages would benefit from consistency. Any objection to command status last?
The text was updated successfully, but these errors were encountered:
Nope :-)
Sorry, something went wrong.
vronchetti
No branches or pull requests
Sequence ID and command status (the last two parameters) are flipped:
aecp_controller_state_machine.cpp:
acmp_controller_state_machine.cpp:
An application that parses "RESPONSE_RECEIVED" type log messages would benefit from consistency. Any objection to command status last?
The text was updated successfully, but these errors were encountered: