Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMP and AECP have a different post_log_msg parameter order #289

Open
vronchetti opened this issue Aug 23, 2016 · 1 comment
Open

ACMP and AECP have a different post_log_msg parameter order #289

vronchetti opened this issue Aug 23, 2016 · 1 comment
Assignees

Comments

@vronchetti
Copy link

Sequence ID and command status (the last two parameters) are flipped:

aecp_controller_state_machine.cpp:

            log_imp_ref->post_log_msg(LOGGING_LEVEL_ERROR,
                                      "RESPONSE_RECEIVED, 0x%llx, %s, %s, %d, %d, %s",
                                      jdksavdecc_uint64_get(&id, 0),
                                      utility::aem_cmd_value_to_name(cmd_type),
                                      utility::aem_desc_value_to_name(desc_type),
                                      desc_index,
                                      jdksavdecc_aecpdu_common_get_sequence_id(frame, ETHER_HDR_SIZE),
                                      utility::aem_cmd_status_value_to_name(status));

acmp_controller_state_machine.cpp:

            log_imp_ref->post_log_msg(LOGGING_LEVEL_ERROR,
                                      "RESPONSE_RECEIVED, 0x%llx, %s, %s, %s, %s, %d",
                                      end_station_entity_id,
                                      utility::acmp_cmd_value_to_name(msg_type),
                                      "NULL",
                                      "NULL",
                                      utility::acmp_cmd_status_value_to_name(status),
                                      seq_id);

An application that parses "RESPONSE_RECEIVED" type log messages would benefit from consistency. Any objection to command status last?

@vronchetti vronchetti self-assigned this Aug 23, 2016
@ahogen
Copy link
Contributor

ahogen commented Aug 31, 2017

Nope :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants