Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/horoscope handler #358

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Feat/horoscope handler #358

wants to merge 12 commits into from

Conversation

fibonacci998
Copy link
Member

No description provided.

@fibonacci998 fibonacci998 requested a review from peara September 7, 2023 02:18
@peara
Copy link
Member

peara commented Sep 7, 2023

@fibonacci998 sửa cái readme đi em, có cả link subquery kia, viết lại theo cách khác đi

@fibonacci998
Copy link
Member Author

@fibonacci998 sửa cái readme đi em, có cả link subquery kia, viết lại theo cách khác đi

em xóa tạm cái doc đi nhé, chưa có tên cho con node với code cũng chưa có gì mấy, mới chỉ draft ra để node bên kia ghép thử nên cũng chưa có doc gì

.andWhere('height', '<', endBlock);

const queryTransaction = Transaction.query()
.select('height', 'hash', 'code', 'codespace', 'memo', 'index')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hiện tại thì chỉ trả về transaction thành công thôi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chỗ này em chưa có handle gì filter ấy, nên em trả hết ra luôn thôi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ý là mặc định là tx thành công ấy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tức là không có cái filter includeTxFail ấy hả anh

queryBlock,
queryTransaction,
]);
resultTransaction.forEach((transaction) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chỗ này thêm order height cho cả block với tx rồi cứ thế đẩy vào thôi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mà sao ko join luôn được ở trên em? nó to quá à?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

em tách ra để handle filter ở từng câu cho dễ ấy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lúc sau có filter em phải thêm 1 đống where vào, sợ để ở 1 câu thì to quá nên tách ra

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thế thêm order rồi sửa cái vòng for là được

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sửa vòng for là sao anh nhỉ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@fibonacci998 fibonacci998 requested a review from peara September 7, 2023 07:45
if (resultGroupBy[height].length > 0) {
if (resultGroupBy[height][0] instanceof Block) {
const data: any = resultGroupBy[height][0];
if (resultGroupBy[height].length > 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anh nghĩ nếu ko có cũng nên cho txs là mảng rỗng hay gì đó
thì mới viết type cho nó được

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@fibonacci998 fibonacci998 force-pushed the feat/horoscope-handler branch from 60c7214 to ccfeee2 Compare February 20, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants