-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/horoscope handler #358
base: main
Are you sure you want to change the base?
Conversation
@fibonacci998 sửa cái readme đi em, có cả link subquery kia, viết lại theo cách khác đi |
em xóa tạm cái doc đi nhé, chưa có tên cho con node với code cũng chưa có gì mấy, mới chỉ draft ra để node bên kia ghép thử nên cũng chưa có doc gì |
.andWhere('height', '<', endBlock); | ||
|
||
const queryTransaction = Transaction.query() | ||
.select('height', 'hash', 'code', 'codespace', 'memo', 'index') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hiện tại thì chỉ trả về transaction thành công thôi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chỗ này em chưa có handle gì filter ấy, nên em trả hết ra luôn thôi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ý là mặc định là tx thành công ấy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tức là không có cái filter includeTxFail ấy hả anh
queryBlock, | ||
queryTransaction, | ||
]); | ||
resultTransaction.forEach((transaction) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chỗ này thêm order height cho cả block với tx rồi cứ thế đẩy vào thôi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mà sao ko join luôn được ở trên em? nó to quá à?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
em tách ra để handle filter ở từng câu cho dễ ấy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lúc sau có filter em phải thêm 1 đống where vào, sợ để ở 1 câu thì to quá nên tách ra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thế thêm order rồi sửa cái vòng for là được
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sửa vòng for là sao anh nhỉ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
if (resultGroupBy[height].length > 0) { | ||
if (resultGroupBy[height][0] instanceof Block) { | ||
const data: any = resultGroupBy[height][0]; | ||
if (resultGroupBy[height].length > 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anh nghĩ nếu ko có cũng nên cho txs là mảng rỗng hay gì đó
thì mới viết type cho nó được
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
5d78ec9
to
60c7214
Compare
* fix: display json on multiple lines * fix: update launch.json to debug jest in 1 file; use moleculer.config.ts when debug service
60c7214
to
ccfeee2
Compare
No description provided.