Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: erc20 update total supply #863

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

phamphong9981
Copy link
Collaborator

@phamphong9981 phamphong9981 commented Jul 24, 2024

  • Fix erc20 convert coin/erc20 logic: mint/burn erc20 not from erc20 module account. It is caused by normal mint/burn (openzepplin), so update address => ZERO_ADDRESS
  • Update total_supply: if transfer from (to) zero => add (sub) total_supply

@phamphong9981 phamphong9981 added bug Something isn't working develop labels Jul 24, 2024
@phamphong9981 phamphong9981 requested a review from peara July 24, 2024 08:59
@phamphong9981 phamphong9981 self-assigned this Jul 24, 2024
@phamphong9981
Copy link
Collaborator Author

@peara peara merged commit c97ec7c into develop Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants