-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS and HTML distribution #327
Comments
@EisenbergEffect @ZHollingshead can you give some input based on the |
Is there a reason we can not set the individual pieces up as regular custom component modules like so? ux-dialog.ts import { customElement } from 'aurelia-templating';
@customElement('ux-dialog')
export class UxDialog {
} ux-dialog.html <template>
<require from="./ux-dialog.css"></require>
<slot></slot>
</template> ux-dialog.css ux-dialog {
display: table;
box-shadow: 0 5px 15px rgba(0, 0, 0, .5);
border: 1px solid rgba(0, 0, 0, .2);
border-radius: 5px;
padding: 3px;
min-width: 300px;
width: -moz-fit-content;
width: -webkit-fit-content;
width: fit-content;
height: -moz-fit-content;
height: -webkit-fit-content;
height: fit-content;
margin: auto;
border-image-source: initial;
border-image-slice: initial;
border-image-width: initial;
border-image-outset: initial;
border-image-repeat: initial;
background: #fff
} |
@ZHollingshead the current approach is towards zero-configuration(minimum) for loader/bundler. That's the only reason for the current setup. |
Please reconsider. |
I'm submitting a feature request
1.0.0-rc.1.0.3
Please tell us about your environment:
Operating System:
all
Node Version:
6.2.0
NPM Version:
3.8.9
JSPM OR Webpack AND Version
all
Browser:
all
Language:
all
Current behavior:
The styles are inlined in src/dialog-configuration.ts.
The views are also inlined using the
@inlineView
.Expected/desired behavior:
What is the expected behavior?
We should get them out in a separate file/s. At least the styles.
What is the motivation / use case for changing the behavior?
Currently the styles - that one-liner, are nightmare to maintain. Also the html can not be minified.
The text was updated successfully, but these errors were encountered: