Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings.json does not define dependency versions #377

Open
Mobe91 opened this issue Jul 9, 2019 · 2 comments
Open

typings.json does not define dependency versions #377

Mobe91 opened this issue Jul 9, 2019 · 2 comments

Comments

@Mobe91
Copy link

Mobe91 commented Jul 9, 2019

Current behavior:
When installing typings using e.g. typings install --save github:aurelia/dialog#1.1.0, the typings tool uses the master version of dependencies defined in aurelia/dialog/typings.json because no versions are defined. This just broke my build unexpectedly because the typings in the dependency masters changed.

Expected/desired behavior:
aurelia/dialog/typings.json should specify dependency versions.

@joelowrance
Copy link
Contributor

@Mobe91 Are you seeing errors like the ones at the bottom of this issue?

aurelia/dependency-injection#178

typings\modules\aurelia-dialog\index.d.ts(2577,1): error TS2668: 'export' modifier cannot be applied to ambient modules and module augmentations since they are always visible.
typings\modules\aurelia-dialog\index.d.ts(2632,170): error TS2536: Type 'number' cannot be used to index type 'TArgs'.
typings\modules\aurelia-dialog\index.d.ts(2638,122): error TS2536: Type 'number' cannot be used to index type 'TArgs'.
typings\modules\aurelia-validation\index.d.ts(496,9): error TS2707: Generic type 'Lazy<TBase, TImpl, TArgs>' requires between 1 and 3
type arguments.

@Mobe91
Copy link
Author

Mobe91 commented Jul 10, 2019

@joelowrance exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants