refactor(webpack): cleanup promise-polyfill, aurelia-dialog patch for IE11 #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In local env, I saw protractor failure (similiar to the docker failure) But docker failure log did not have the exact log of I was able to fix my local protractor issue by upgrading Chrome to latest version. |
|
@3cp I'll check it tonight, we install chrome in the Docker file and I guess we should also update that to the latest version. But it is weird that only some of them failed, and not all, while all of them use the same configuration for tools installed inside the container. |
When running chrome-driver via protractor it fails with `DevToolsActivePort file doesn't exist`, two arguments should be passed to chrome based on the discussions [here](puppeteer/puppeteer#1834), [here](https://stackoverflow.com/questions/50642308/webdriverexception-unknown-error-devtoolsactiveport-file-doesnt-exist-while-t), and [here](SeleniumHQ/selenium#6049 (comment))
|
Good, all docker tests passed. Not sure why it did not run on your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move promise-polyfill from ProviderPlugin to entry.
Add aurelia-dialog patch for IE11, but user needs to uncomment it.
Closes aurelia/dialog#387