Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote aurelia-typed-observable plugin to official and add docs #411

Open
zewa666 opened this issue May 25, 2019 · 14 comments
Open

Promote aurelia-typed-observable plugin to official and add docs #411

zewa666 opened this issue May 25, 2019 · 14 comments

Comments

@zewa666
Copy link
Member

zewa666 commented May 25, 2019

Just today I again stumbled across this great plugin https://github.com/aurelia-contrib/aurelia-typed-observable-plugin which definitely deserves more visibility. How about promoting it to an official one and adding some docs @EisenbergEffect, @bigopon ?

@EisenbergEffect
Copy link
Contributor

@bigopon How much code is it? This is something I'd be interested in having in the core for vNext actually, but we could keep the plugin for vCurrent. Thoughts?

@bigopon
Copy link
Member

bigopon commented May 25, 2019

For vNext, its simple to add, and should in core.
Back to the Q, for vCurrent, how do we promote the plugin to an official one?

@zewa666
Copy link
Member Author

zewa666 commented May 26, 2019

@EisenbergEffect creates a new repo, gives you write permissions and off you go with the Initial commit.

I also like the idea of having this in core for vNext but so far the Plugin approach is good. Essentially what it really boils down to is having an official documentation and the proof for consumers that it will be maintained

@EisenbergEffect
Copy link
Contributor

Yep, @bigopon I could set up a repo for you under the aurelia org and then we just need to add a doc to the plugins section of our site. You want to go for it?

@bigopon
Copy link
Member

bigopon commented May 27, 2019

@EisenbergEffect the plugins require devs to import decorators from there, not from core module. Does it look good for an official plugin?

@EisenbergEffect
Copy link
Contributor

I think it's something we can live with for now as we transition to vNext.

@zewa666
Copy link
Member Author

zewa666 commented May 27, 2019

I'd agree. Importing from other Plugin packages shouldnt be an issue If we clearly document this, maybe even with a hint that it wont be necessary in vNext

@bigopon
Copy link
Member

bigopon commented May 31, 2019

Changing from its current repo to aurelia org is easy. What do we want to do with release on npm? And potentially pagkage name as well?

@3cp
Copy link
Member

3cp commented Jun 1, 2019

npm has command to remove all existing versions.

But you need to wait 24 hrs (some npmjs policy) before republish it under different npm user name. For safety, you'd better republish all versions.

@bigopon
Copy link
Member

bigopon commented Jun 1, 2019

@EisenbergEffect @zewa666 any comments on what @3cp and @bigopon said?

@EisenbergEffect
Copy link
Contributor

For the NPM release, you just need to make AureliaEffect an owner. I don't think there's a need to change the name or republish stuff.

@michaelw85
Copy link
Contributor

I would very much like to see this made official or even better moved into the core (not just vnext). I've looked for type coercion in the past and today I was looking for default binding mode for view only components and stumbled upon aurelia/templating-resources#309

Can I pitch in to make this happen?

@bigopon
Copy link
Member

bigopon commented Jun 11, 2019

@michaelw85 that'd be awesome. But the first thing we need to sort out is the scope of the plugin. At the moment, it's for coercing value, we can expand it to provide a few extra bits of functionalities

@EisenbergEffect

@EisenbergEffect
Copy link
Contributor

I'd like to get the plugin made official as is first. Then, I'd like to build this and the other issue into vNext. Once that's done, we should look at what the best way to realize this feature is in vCurrent. This will ensure that vCurrent is at least a strict subset of vNext and help us make them compatible.

@bigopon I know Fred is in the middle of a big refactor on vNext. Maybe check with him on this. If this work is mostly restricted, at least at first, to the template compiler, then you might be able to work on it in parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants