taxonomy hook with a filter

[netzgestaltung]

in /includes/class-cf7-2-post-factory.php on line 1442 the true condition leads to adding an empty array instead of a filter function.

if( 0 === strpos($form_field,'cf7_2_post_filter-') ) {
  $value = apply_filters($form_field, array(), $post_id, $cf7_form_data);
}

i think there should be 'cf7_2_post_filter-' . $this->post_properties['type'] . '-' . $field_to_map instead of that empty array. Also the usage of $this->post_properties['type'] seems unconsistent sometimes with and somethimes without.

[netzgestaltung]

i will inspect my issue more after reading some docs

[aurovrata]

i think there should be 'cf7_2_post_filter-' . $this->post_properties['type'] . '-' . $field_to_map

this is to identiy the field in the form? When I created the plugin, I wasn't very consistent in my creation of filters. I would change this filter to:

$value = apply_filters($form_field, array(), $post_id, $cf7_form_data, $cf7_key);

which would allow a user to identify the form being submitted.

Also the usage of $this->post_properties['type'] seems unconsistent sometimes with and somethimes without.

yes, that's quite possible, and hopefully can be improved in v5

[netzgestaltung]

please refer to #9 where i figured it all out.

i think a filter should not only get an empty array but instead the possible estimated value instead

[aurovrata]

i think a filter should not only get an empty array

Well, if multiple functions are hooked then you want the same value type to be passed, in this case an array.

instead the possible estimated value instead

in this case there is no estimated value, since the user opts for the filtered option (ie no form fields mapped here).

[aurovrata]

I am going through the code and creating a Wiki Page on key functionality in processes handled by the plugin.