Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable Carto #62

Open
aussig opened this issue Oct 20, 2022 · 0 comments
Open

Editable Carto #62

aussig opened this issue Oct 20, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@aussig
Copy link
Owner

aussig commented Oct 20, 2022

The game sometimes bugs and fails to log cartography. Although there's nothing we can directly do about this, instead make the carto fields editable so that the user can manually enter their carto if this happens.

This isn't quite as straightforward as making the on-screen field editable, because the value is abbreviated with e.g. 'k', 'm', 'b' etc. A couple of options:

  1. Make the field directly editable, allow the user to enter abbreviations too (e.g. '3.75m'), then parse it into an integer.
  2. Add an 'Edit' button, which temporarily makes the field directly editable, showing the integer value and then 'save' makes it read-only again and shows the abbreviated value.
  3. When a field is clicked, temporarily make it directly editable, showing the integer value and then clicking away makes it read-only again and shows the abbreviated value.
  4. Add an 'Edit' button which pops up a modal, showing the integer value and allowing a number to be entered. When closed, the value is then updated on the main window.

I like option 3 best, though it needs to be obvious you can click the field (compared to pure read-only values).

@aussig aussig added the enhancement New feature or request label Oct 20, 2022
@aussig aussig added this to the 2.1.0 milestone Oct 20, 2022
@aussig aussig self-assigned this Oct 20, 2022
@aussig aussig modified the milestones: 2.1.0, 2.3.0 Dec 13, 2022
@aussig aussig removed their assignment Dec 30, 2022
@aussig aussig modified the milestones: 2.3.0, 3.1.0 Jan 25, 2023
@aussig aussig modified the milestones: 3.1.0, Backlog Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant