-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser tests #13
Comments
@mattbierner I haven't published my changes yet, but I added browser support to this module. Do you mind testing it with your use case? |
My use case of the Giphy api is pretty simple: just the search api with the public key (example project). The project is also using webpack for building, so it may not be the use case you are targeting. I did install the latest bits though and confirmed they still work fine with webpack. You can also include To tests things more directly, I also tried using the Again, not sure how useful that is beyond confirming that the basic functionality still works. Please let me know if any other info would be helpful. |
Thanks for taking a look. I added |
With the newly implemented browser bundling, we should introduce a web testing framework (perhaps phantomjs).
The text was updated successfully, but these errors were encountered: