Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Application moves past Syncing screen before actually syncing. #264

Open
ImmaZoni opened this issue Jun 15, 2022 · 4 comments · Fixed by #270
Open

Application moves past Syncing screen before actually syncing. #264

ImmaZoni opened this issue Jun 15, 2022 · 4 comments · Fixed by #270
Assignees
Labels
bug Something isn't working

Comments

@ImmaZoni
Copy link
Contributor

I have had multiple users explain that they will be syncing, then all of a sudden the subspace desktop will skip to 100% synced, and go the next screen showing it is fully synced. Or might show they are synced at an incorrect block as shown here https://forum.subspace.network/t/user-stuck-on-early-block/366

My best guess for what is happening is that the % bar on that screen is likely calculated by the nodes Best block #/Target block #

With the various forks nodes are jumping across we see various target block # heights, as such an edge case could appear where the best block #/target block # = 1 (true)

Which may send the application to the next screen even though syncing is not actually complete.

@ImmaZoni ImmaZoni added the bug Something isn't working label Jun 15, 2022
@ozgunozerk
Copy link
Contributor

Your assumption is true.

The problem is occurring at 2 different places:
1- plotting progress page -> when the ratio becomes 1 (due to incorrect heigh of the blockchain), the next button is enabled, and stays enabled. It should not stay enabled. When the ratio is not 1, it should disable the next button again
2- dashboard -> fully synced status is the last state, and there is no transition to any other state from fully synced state. There should a transition to syncing from fully synced as well, due to this potential incorrect block height information.

@isSerge , do you want to handle this? Or I can take care of it as well

@isSerge
Copy link
Contributor

isSerge commented Jun 16, 2022

@ozgunozerk let me take this one

@isSerge isSerge self-assigned this Jun 16, 2022
@isSerge isSerge moved this from Todo to In Progress in Product Engineering Jun 20, 2022
@isSerge isSerge linked a pull request Jun 22, 2022 that will close this issue
Repository owner moved this from In Progress to Done in Product Engineering Jun 22, 2022
@isSerge
Copy link
Contributor

isSerge commented Jun 22, 2022

In order to close this one, we need to update UI so there is a transition from synced back to syncing (in case of incorrect block height or any other changes)

@isSerge isSerge reopened this Jun 22, 2022
Repository owner moved this from Done to Todo in Product Engineering Jun 22, 2022
@isSerge isSerge moved this from Todo to Blocked in Product Engineering Aug 2, 2022
@achiurizo
Copy link
Contributor

#238

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

4 participants