Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

UI optimization for syncing progress highestBlock value #282

Conversation

isSerge
Copy link
Contributor

@isSerge isSerge commented Jul 12, 2022

only update the highest block if the new value is bigger

@isSerge isSerge requested a review from nazar-pc July 12, 2022 13:28
@isSerge isSerge self-assigned this Jul 12, 2022
@isSerge isSerge linked an issue Jul 12, 2022 that may be closed by this pull request
Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a sufficient fix. If you connect to a node on non-canonical fork that has a higher block height, application will get stuck in syncing state forever. This needs to be smarter than that somehow.

@isSerge
Copy link
Contributor Author

isSerge commented Jul 12, 2022

@nazar-pc in that case we could notify the user that he/she is on the non-canonical fork and provide steps to fix this. But it seems like a separate task to me

@nazar-pc
Copy link
Member

That is the problem: we do not know. There was a higher block number observable, but we can't know if that was the canonical chain we should reach eventually or some random fork we should ignore.

What about remembering highest block number of some time, but revert back to the currently visible in case it doesn't change much for a long time? Otherwise I'd leave the behavior as is, at least it accurately shows what node is currently thinking the sync target is.

@isSerge
Copy link
Contributor Author

isSerge commented Jul 12, 2022

@nazar-pc probably worth discussing on the next Apps sync, will let you know if we make a decision

@isSerge isSerge closed this Jul 14, 2022
@isSerge isSerge deleted the 281-ui-optimization-for-syncing-progress-highestblock-value branch July 14, 2022 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI optimization for syncing progress highestBlock value
2 participants