Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't handle $ or £ in excel price column #2

Open
autotelik opened this issue Mar 19, 2012 · 2 comments
Open

Doesn't handle $ or £ in excel price column #2

autotelik opened this issue Mar 19, 2012 · 2 comments
Labels

Comments

@autotelik
Copy link
Owner

If the Price column is a currency type containing symbol get a very nasty bug where the Product saves and save returns true but there is no master Variant. This is particularly nasty as will crash the main site as Products found, but access to master causes no method errors on nil.

Presume the price field is set to something on Master, not nil, so Product saves but then the underlying Variant fails to save when checks done on validity of Price field.

Odd since if you leave the Price column completely blank then the Product itself will not save, validation error something like 'Price must be set'

@kewubenduben
Copy link

Hi @autotelik , do you have a fix for this?

@autotelik
Copy link
Owner Author

Hi ... sorry not had much time lately to show this project any love

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants