Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use /tmp for disk attach #3485

Open
qiankehan opened this issue May 14, 2021 · 0 comments
Open

Don't use /tmp for disk attach #3485

qiankehan opened this issue May 14, 2021 · 0 comments

Comments

@qiankehan
Copy link
Contributor

qiankehan commented May 14, 2021 •
edited
Loading

Since qemu v5.2.0-rc0~110^2~1 util: give a specific error message when O_DIRECT doesn't work, it will report error when try to live attach file disk source from /tmp:

internal error: unable to execute QEMU command 'blockdev-add': Could not open '/tmp/disk-raw': filesystem does not support O_DIRECT

It seems some disk sources still use /tmp:

libvirt/tests/src/virsh_cmd/domain/virsh_detach_device.py:30:    def create_device_file(device_source="/tmp/attach.img"):

Here is why tmpfs cannot support O_DIRECT: https://lists.archive.carbon60.com/linux/kernel/720702

@chunfuwen @Yingshun @dzhengfy
nanli1 pushed a commit to nanli1/tp-libvirt that referenced this issue Feb 1, 2023
@luckyh
Merge pull request autotest#3485 from yanan-fu/uuid_dimm
bfa5e5d 
dimm: get accurate device params and distinguish attributes by dimm_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qiankehan