Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_avoidance_planner ): rework parameters #7287

Closed

Conversation

Ariiees
Copy link
Contributor

@Ariiees Ariiees commented Jun 5, 2024

Description

Implement the ROS Node configuration layout for the obstacle_avoidance_planner package.

Remove the default value from the source code in all declare_parameter() functions.
Create the JSON Schema for all parameters used in the declare_parameter() function.

Note: Nothing change in *.param.yaml file

Test performed

  1. Build colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to obstacle_avoidance_planner --parallel-workers 5
  2. Launch ros2 launch obstacle_avoidance_planner obstacle_avoidance_planner.launch.xml

Notes for reviewers

  1. obstacle_avoidance_planner disappeared in the latest GitHub main branch.
  2. There is a launch error in the original autoware.universe code. The updated version gets the same error.

Interface Changes

  1. remove default values in mpt_optimizer.cpp 's declare_parameter()
  2. Create according obstacle_avodiance_planner.schema.json
  3. Update README.md

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.
    After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 5, 2024
@Ariiees Ariiees changed the title obstacle_avoidance_planner node configuration refactor(obstacle_avoidance_planner ): rework parameters Jun 5, 2024
@Ariiees Ariiees closed this Jun 7, 2024
@Ariiees
Copy link
Contributor Author

Ariiees commented Jun 7, 2024

Node closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant