Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_pointcloud_preprocessor): launch file load parameter from yaml #8129

Merged
merged 9 commits into from
Nov 7, 2024

chore: remove filter base

b97aad8
Select commit
Loading
Failed to load commit list.
Merged

fix(autoware_pointcloud_preprocessor): launch file load parameter from yaml #8129

chore: remove filter base
b97aad8
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 7, 2024 in 33s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.09 (9.52 -> 9.43)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method preprocessor.launch.py: launch_setup

Annotations

Check warning on line 135 in sensing/autoware_pointcloud_preprocessor/launch/preprocessor.launch.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

launch_setup increases from 111 to 121 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis