refactor(autoware_pointcloud_preprocessor): rework concatenate_pointcloud and time_synchronizer_node parameters #8509
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /**: | ||
| ros__parameters: | ||
| output_frame: base_link | ||
| input_topics: [ | ||
| "/sensing/lidar/left/pointcloud_before_sync", | ||
| "/sensing/lidar/right/pointcloud_before_sync", | ||
| "/sensing/lidar/top/pointcloud_before_sync" | ||
| ] | ||
| max_queue_size: 5 | ||
| timeout_sec: 0.033 | ||
| input_offset: [0.0 ,0.0 ,0.0] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| /**: | ||
| ros__parameters: | ||
| input_twist_topic_type: twist | ||
| output_frame: base_link | ||
| keep_input_frame_in_synchronized_pointcloud: false | ||
| input_topics: [ | ||
| "/sensing/lidar/left/pointcloud_before_sync", | ||
| "/sensing/lidar/right/pointcloud_before_sync", | ||
| "/sensing/lidar/top/pointcloud_before_sync" | ||
| ] | ||
| synchronized_pointcloud_postfix: pointcloud | ||
| max_queue_size: 5 | ||
| timeout_sec: 0.1 | ||
| input_offset: [0.0, 0.0, 0.0] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <launch> | ||
| <arg name="output" default="/sensing/lidar/concatenated/pointcloud"/> | ||
| <!-- Parameter --> | ||
| <arg name="param_file" default="$(find-pkg-share autoware_pointcloud_preprocessor)/config/concatenate_pointclouds.param.yaml"/> | ||
| <node pkg="autoware_pointcloud_preprocessor" exec="concatenate_pointclouds_node" name="concatenate_pointclouds_node" output="screen"> | ||
| <remap from="output" to="$(var output)"/> | ||
| <param from="$(var param_file)"/> | ||
| </node> | ||
| </launch> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <launch> | ||
| <arg name="input/twist" default="/sensing/vehicle_velocity_converter/twist_with_covariance"/> | ||
| <!-- Parameter --> | ||
| <arg name="param_file" default="$(find-pkg-share autoware_pointcloud_preprocessor)/config/time_synchronizer_node.param.yaml"/> | ||
| <node pkg="autoware_pointcloud_preprocessor" exec="time_synchronizer_node" name="time_synchronizer_node" output="screen"> | ||
| <remap from="~/input/twist" to="$(var input/twist)"/> | ||
| <param from="$(var param_file)"/> | ||
| </node> | ||
| </launch> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "title": "Parameters for Concatenate Pointclouds Node", | ||
| "type": "object", | ||
| "definitions": { | ||
| "concatenate_pointclouds": { | ||
| "type": "object", | ||
| "properties": { | ||
| "timeout_sec": { | ||
| "type": "number", | ||
| "default": 0.1, | ||
| "description": "Tolerance of time to publish the next pointcloud [s]. When this time limit is exceeded, the filter concatenates and publishes pointcloud, even if not all the point clouds are subscribed." | ||
| }, | ||
| "input_offset": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "number" | ||
| }, | ||
| "default": [], | ||
| "description": "This parameter can control waiting time for each input sensor pointcloud [s]. You must to set the same length of offsets with input pointclouds numbers." | ||
| }, | ||
| "output_frame": { | ||
| "type": "string", | ||
| "default": "base_link", | ||
| "description": "Output frame id." | ||
| }, | ||
| "input_topics": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "default": [], | ||
| "description": "List of input topics." | ||
| }, | ||
| "max_queue_size": { | ||
| "type": "integer", | ||
| "default": 5, | ||
|
There was a problem hiding this comment. Assign default values as string |
||
| "description": "Max queue size of input/output topics." | ||
| } | ||
| }, | ||
| "required": ["timeout_sec", "input_offset", "output_frame", "input_topics", "max_queue_size"] | ||
| } | ||
| }, | ||
| "properties": { | ||
| "/**": { | ||
| "type": "object", | ||
| "properties": { | ||
| "ros__parameters": { | ||
| "$ref": "#/definitions/concatenate_pointclouds" | ||
| } | ||
| }, | ||
| "required": ["ros__parameters"] | ||
| } | ||
| }, | ||
| "required": ["/**"] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "title": "Parameters for Time synchronizer Node", | ||
| "type": "object", | ||
| "definitions": { | ||
| "time_synchronizer": { | ||
| "type": "object", | ||
| "properties": { | ||
| "timeout_sec": { | ||
| "type": "number", | ||
| "default": 0.033, | ||
|
There was a problem hiding this comment. Assign default values as string |
||
| "description": "Tolerance of time to publish the next pointcloud [s]. When this time limit is exceeded, the filter concatenates and publishes pointcloud, even if not all the point clouds are subscribed." | ||
| }, | ||
| "input_offset": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "number" | ||
| }, | ||
| "default": [], | ||
| "description": "This parameter can control waiting time for each input sensor pointcloud [s]. You must to set the same length of offsets with input pointclouds numbers." | ||
| }, | ||
| "input_twist_topic_type": { | ||
| "type": "string", | ||
| "enum": ["twist", "odom"], | ||
| "default": "twist", | ||
| "description": "Topic type for twist. Currently supports 'twist' or 'odom'." | ||
| }, | ||
| "output_frame": { | ||
| "type": "string", | ||
| "default": "base_link", | ||
| "description": "Output frame." | ||
| }, | ||
| "keep_input_frame_in_synchronized_pointcloud": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Flag to indicate if input frame should be kept in synchronized point cloud." | ||
| }, | ||
| "input_topics": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "default": [], | ||
| "description": "List of input topics." | ||
| }, | ||
| "synchronized_pointcloud_postfix": { | ||
| "type": "string", | ||
| "default": "pointcloud", | ||
| "description": "Postfix for the synchronized point cloud." | ||
| }, | ||
| "max_queue_size": { | ||
| "type": "integer", | ||
| "default": 5, | ||
|
There was a problem hiding this comment. Assign default values as string |
||
| "description": "Max queue size of input/output topics." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "timeout_sec", | ||
| "input_offset", | ||
| "input_twist_topic_type", | ||
| "output_frame", | ||
| "keep_input_frame_in_synchronized_pointcloud", | ||
| "input_topics", | ||
| "synchronized_pointcloud_postfix", | ||
| "max_queue_size" | ||
| ] | ||
| } | ||
| }, | ||
| "properties": { | ||
| "/**": { | ||
| "type": "object", | ||
| "properties": { | ||
| "ros__parameters": { | ||
| "$ref": "#/definitions/time_synchronizer" | ||
| } | ||
| }, | ||
| "required": ["ros__parameters"] | ||
| } | ||
| }, | ||
| "required": ["/**"] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assign default values as string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! fixed them in 08ec218