-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(traffic_light_recognition_marker_publisher): prefix package and namespace with autoware #9305
refactor(traffic_light_recognition_marker_publisher): prefix package and namespace with autoware #9305
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
baaecf1
to
c03da79
Compare
c03da79
to
25bed5e
Compare
Pull request was converted to draft
25bed5e
to
8f25c28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9305 +/- ##
==========================================
- Coverage 30.06% 30.03% -0.03%
==========================================
Files 1340 1341 +1
Lines 103645 103735 +90
Branches 40341 40357 +16
==========================================
Hits 31158 31158
- Misses 69480 69570 +90
Partials 3007 3007
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 2 in 7a19e8a
<node pkg="traffic_light_recognition_marker_publisher" exec="traffic_light_recognition_marker_publisher_node" name="traffic_light_recognition_marker_publisher"> |
This launch file needs to be updated too.
@xmfcx I used |
Interesting, let me try that again, I'd like to see how it fails. I've added information on why we should use refactor here. |
It did not fail here: Until it fails again, can we go with |
@xmfcx sure, no problem |
8f25c28
to
4180cc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests pass and I see the references are updated correctly. Thanks @esteve .
@tkimura4 @1222-takeshi @shmpwk please review.
Since it's been more than a week since the review was requested, I will merge it tomorrow.
…and namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]>
adcb1b2
to
fab91ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
prefix package and namespace with
autoware
Related links
Parent Issue:
autoware.universe/common
packages autoware#5077How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.