Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(traffic_light_recognition_marker_publisher): prefix package and namespace with autoware #9305

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 12, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 12, 2024
@esteve esteve marked this pull request as ready for review November 12, 2024 13:47
@esteve esteve force-pushed the prefix-traffic_light_recognition_marker_publisher branch from baaecf1 to c03da79 Compare November 13, 2024 10:42
@esteve esteve enabled auto-merge (squash) November 13, 2024 10:42
@esteve esteve self-assigned this Nov 13, 2024
@esteve esteve force-pushed the prefix-traffic_light_recognition_marker_publisher branch from c03da79 to 25bed5e Compare November 18, 2024 10:32
@esteve esteve marked this pull request as draft November 19, 2024 14:30
auto-merge was automatically disabled November 19, 2024 14:30

Pull request was converted to draft

@esteve esteve force-pushed the prefix-traffic_light_recognition_marker_publisher branch from 25bed5e to 8f25c28 Compare November 19, 2024 14:37
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.03%. Comparing base (6c20d58) to head (fab91ad).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9305      +/-   ##
==========================================
- Coverage   30.06%   30.03%   -0.03%     
==========================================
  Files        1340     1341       +1     
  Lines      103645   103735      +90     
  Branches    40341    40357      +16     
==========================================
  Hits        31158    31158              
- Misses      69480    69570      +90     
  Partials     3007     3007              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 30.06% <ø> (ø) Carriedforward from 6c20d58

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@esteve esteve marked this pull request as ready for review November 19, 2024 15:39
@xmfcx xmfcx changed the title chore(traffic_light_recognition_marker_publisher): prefix package and namespace with autoware refactor(traffic_light_recognition_marker_publisher): prefix package and namespace with autoware Nov 20, 2024
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<node pkg="traffic_light_recognition_marker_publisher" exec="traffic_light_recognition_marker_publisher_node" name="traffic_light_recognition_marker_publisher">

This launch file needs to be updated too.

@esteve esteve changed the title refactor(traffic_light_recognition_marker_publisher): prefix package and namespace with autoware chore(traffic_light_recognition_marker_publisher): prefix package and namespace with autoware Nov 20, 2024
@esteve
Copy link
Contributor Author

esteve commented Nov 20, 2024

@xmfcx I used chore because refactor is not a valid label, my PRs always failed the pr-label check because of that. I've reverted your change.

@xmfcx
Copy link
Contributor

xmfcx commented Nov 20, 2024

Interesting, let me try that again, I'd like to see how it fails.

I've added information on why we should use refactor here.

@xmfcx xmfcx changed the title chore(traffic_light_recognition_marker_publisher): prefix package and namespace with autoware refactor(traffic_light_recognition_marker_publisher): prefix package and namespace with autoware Nov 20, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Nov 20, 2024

It did not fail here:

Until it fails again, can we go with refactor?

@esteve
Copy link
Contributor Author

esteve commented Nov 20, 2024

@xmfcx sure, no problem

@esteve esteve force-pushed the prefix-traffic_light_recognition_marker_publisher branch from 8f25c28 to 4180cc0 Compare November 20, 2024 12:15
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests pass and I see the references are updated correctly. Thanks @esteve .

@tkimura4 @1222-takeshi @shmpwk please review.

Since it's been more than a week since the review was requested, I will merge it tomorrow.

Reference: https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/code-owners/#unreviewed-pull-requests

@esteve esteve enabled auto-merge (squash) November 20, 2024 14:35
@esteve esteve disabled auto-merge November 20, 2024 14:35
…and namespace with autoware

Signed-off-by: Esteve Fernandez <[email protected]>
@esteve esteve force-pushed the prefix-traffic_light_recognition_marker_publisher branch from adcb1b2 to fab91ad Compare November 20, 2024 14:37
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx xmfcx merged commit 248bba7 into autowarefoundation:main Nov 21, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants