Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ndt_evaluation #10

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Feb 26, 2024

Description

work in progress

Add scripts for ndt_evaluation

Tests performed

See https://github.com/autowarefoundation/autoware_tools/pull/10/files#diff-d033f999870d49720af4fa74ffa636798ad0d7ee2c4d140a3b9e4130886cab5b

Effects on system behavior

There are no effects on system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

pre-commit-ci bot and others added 2 commits February 26, 2024 08:04
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a directory for this script like
localization/<directory_name>/script/convert_rosbag_for_ndt_evlauation.py ?

Plus, there should be a brief README.md for this script that contains

  • What does this do?
  • How to use this?
    Just like you wrote in the PR description.

@SakodaShintaro
Copy link
Contributor Author

@TaikiYamada4
Thanks! I will develop a little more.
This pull request will be a draft.

Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro SakodaShintaro changed the title feat: add convert_rosbag_for_ndt_evaluation.py feat: add ndt_evaluation Feb 26, 2024
SakodaShintaro and others added 4 commits March 5, 2024 11:33
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Copy link
Contributor Author

Some changes in this PR have been merged into other repositories. This PR is now closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants