Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(global_parameter_loader): prefix package and namespace with autoware #159

Merged

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 20, 2024

Description

Related links

autowarefoundation/autoware.universe#9303
autowarefoundation/autoware#5077
autowarefoundation/autoware#4569

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for planning/autoware_planning_data_analyzer/launch/behavior_analyzer.launch.xml

@xmfcx xmfcx self-requested a review December 4, 2024 13:27
@xmfcx xmfcx force-pushed the prefix-global_parameter_loader branch from efcf01f to d3de769 Compare December 4, 2024 13:27
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmfcx xmfcx merged commit a44fdf8 into autowarefoundation:main Dec 4, 2024
30 checks passed
@esteve esteve deleted the prefix-global_parameter_loader branch December 4, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants