Add ACP-176 e2e tests #3749
Draft
Add ACP-176 e2e tests #3749
+242
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Feb 27, 2025
Comment on lines
-4
to
-5
| // AUTOMATICALLY GENERATED. DO NOT EDIT! | ||
| // Generated from hashing.sol by compile-contract.sh |
There was a problem hiding this comment.
This file doesn't seem to have ever been checked in to the repo (even going back to when this file was originally added to the kurtosis e2e tests).
StephenButtolph
commented
Feb 27, 2025
| @@ -183,7 +183,12 @@ func SendEthTransaction(tc tests.TestContext, ethClient ethclient.Client, signed | |||
| return true | |||
| }, DefaultTimeout, DefaultPollingInterval, "failed to see transaction acceptance before timeout") | |||
|
|
|||
| require.Equal(types.ReceiptStatusSuccessful, receipt.Status) | |||
There was a problem hiding this comment.
This implied that we would only want to issue successful transactions. The gas consumption in this PR actually expects the transaction to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR:
post_fortunae2e CI run.SuggestGasPriceas the price APIs do not seem reliable. We should consider changing how the price APIs work from inspecting prior blocks to just returning the next baseFee.How this works
Just modifying tests.
How this was tested
CI
Need to be documented in RELEASES.md?
No.