Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masterfile Management Doesn't Work for Google Drive and Sharepoint #6152

Open
1 task
joncameron opened this issue Dec 17, 2024 · 6 comments
Open
1 task

Masterfile Management Doesn't Work for Google Drive and Sharepoint #6152

joncameron opened this issue Dec 17, 2024 · 6 comments
Labels

Comments

@joncameron
Copy link
Contributor

joncameron commented Dec 17, 2024

Description

When masterfile management is configured as 'move' and the file is being retrieved from Google Drive or Sharepoint, the file is not copied as expected to the target directory. This appears to only be occurring for Google Drive and Sharepoint via Browse Everything; the file is being copied as expected for files retrieved from S3 or the file system.

Done Looks Like

  • Files are moved to the expected directory when using the 'move' strategy, regardless of file source
@elynema
Copy link
Contributor

elynema commented Jan 10, 2025

Is this an important enough fix that it should be an 8.1 patch? Will this impact other sites that are using Browse Everything, or is this SDA work that is somewhat local to IU?

At IU, how can we track / find anything uploaded via Google Drive in the past?

This will need to be cherrypicked out to MCO ASAP once fixed or as part of 8.0 release.

@masaball
Copy link
Contributor

Resolved by #6129.

@joncameron
Copy link
Contributor Author

After QA, we may want to cherry-pick to production or add to a patch release to get the fix out for users.

@joncameron
Copy link
Contributor Author

I updated avalon-dev to change the masterfile management strategy to 'move' and specifying /tmp/ as the location. Inside the container, I didn't see the video I uploaded via Google Drive moved to /tmp.

@masaball
Copy link
Contributor

masaball commented Feb 6, 2025

I just checked in the rails console on Dev and Settings.master_file_management.path is returning "s3://preserves". This value is set in the docker_compose file and doesn't seem to be getting overridden by the local settings file. I checked and that bucket does not exist on Avalon-dev so there is nowhere to move the files to.

I'll check with @cjcolvar when he is back in on how we want to approach making the changes for testing.

@elynema
Copy link
Contributor

elynema commented Feb 7, 2025

Expected behavior that docker_compose will override the settings, so not a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants