Remove need for restart after mission upload #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fredrikbjornland
force-pushed
the
aviant/remove-need-for-restart
branch
2 times, most recently
from
51efdfe
to
7dc7db2
Compare
kibidev
requested changes
Oct 18, 2024
Fredrikbjornland
force-pushed
the
aviant/remove-need-for-restart
branch
2 times, most recently
from
8e083be
to
c873896
Compare
Fredrikbjornland
force-pushed
the
aviant/remove-need-for-restart
branch
4 times, most recently
from
0d64612
to
17837c4
Compare
The filename from the previous mission would stay after downloading a new mission from kyte backend
If not, the mission name is still displayed in indicator bar after clearing missin
Avoids cannot read property coordinate and property type of unedfined when clearing delivery point
Displaying mission sync status in maintoolbar instead of PlanToolBarIndicators has two advantages. 1. We want to see the mission sync status at all times, such as in the fly view, not just when the plan view is open. This is the main reasson. 2. This makes it fill the entire window. Currently, the plantoolbar fills ~60% of the screen width, which is missleading for a loading bar
If mission, rally point or geofence upload to drone fails, we dont want to allow arming.
Arming while still syncing mission to drone can lead to unexpected mission on drone while flying. Check for synInProgress before error in MainStatusIndicator to not display "Error" status when syncing mission plan.
Fredrikbjornland
force-pushed
the
aviant/remove-need-for-restart
branch
from
17837c4
to
fe36b82
Compare
kibidev
reviewed
Oct 31, 2024
This is done as we never want the mission from the drone to overwrite the mission in plan view. Removing the popup removes one action for the pilot, which is nice.
Fredrikbjornland
force-pushed
the
aviant/remove-need-for-restart
branch
from
fe36b82
to
621b4ff
Compare
kibidev
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiple features to prevent us from flying with unexpected mission/rallypoint/geofence:
Also some minor fixes: