Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: consider adding milog and snopi #1

Open
senorsmile opened this issue Jul 1, 2020 · 4 comments
Open

feature request: consider adding milog and snopi #1

senorsmile opened this issue Jul 1, 2020 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@senorsmile
Copy link

e.g.
https://milog.co.il/%D7%9B%D7%9E%D7%93%D7%9E%D7%A0%D7%99/e_89779
http://www.snopi.com/xDic/HHdic.aspx?txtId=1888

@avipars
Copy link
Owner

avipars commented Jul 2, 2020

Thank you. I'll see what I can do.

@avipars
Copy link
Owner

avipars commented Jul 2, 2020

in the meantime, if you would like to submit a PR, that can speed this up a lot.

@avipars avipars self-assigned this Jul 2, 2020
@avipars avipars added the good first issue Good for newcomers label Jul 2, 2020
@senorsmile
Copy link
Author

I may have some capacity within my open source time to do that.

@avipars
Copy link
Owner

avipars commented Jul 3, 2020

Cool, I'd be more than happy to accept your improvements.

I am not sure what would be best from a UI perspective.

Also mlog only accepts hebrew input (hebrew-hebrew dictionary), while the other sources allow for both hebrew-english.

Lastly, some sites refuse connection through iframes, otherwise, I would have added Pealim and Bing Translate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants