Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: belongs_to field should use association primary_key #3422

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #3413

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob marked this pull request as draft November 14, 2024 09:05
@github-actions github-actions bot added the Fix label Nov 14, 2024
Copy link

codeclimate bot commented Nov 14, 2024

Code Climate has analyzed commit c611b7d and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-standard id via primary_key option on Belongs To field not respected
1 participant