From 26835c0a78fbe94287754bb62388d900a12d5510 Mon Sep 17 00:00:00 2001
From: Thiago Youssef <43591948+thiagoyoussef@users.noreply.github.com>
Date: Fri, 15 Nov 2024 14:10:53 -0300
Subject: [PATCH 1/4] feature: summarizable associations

---
 app/controllers/avo/charts_controller.rb      | 22 ++++++++++-
 app/views/avo/partials/_table_header.html.erb | 10 +----
 spec/features/avo/field_summarizing_spec.rb   | 37 +++++++++++++++++++
 3 files changed, 60 insertions(+), 9 deletions(-)

diff --git a/app/controllers/avo/charts_controller.rb b/app/controllers/avo/charts_controller.rb
index 5e872c8742..e450af5084 100644
--- a/app/controllers/avo/charts_controller.rb
+++ b/app/controllers/avo/charts_controller.rb
@@ -3,10 +3,30 @@
 module Avo
   class ChartsController < BaseController
     def distribution_chart
-      @values_summary = resource.model_class.group(params[:field_id]).reorder("count_all desc").count
+      @values_summary = records.group(params[:field_id]).reorder("count_all desc").count
+
       @field_id = params[:field_id]
 
       render "avo/partials/distribution_chart", layout: "avo/blank"
     end
+
+    private
+
+    def records
+      if is_associated_record?
+        related_records
+      else
+        resource.model_class
+      end
+    end
+
+    def related_records
+      relation_class = BaseResource.get_model_by_name(params[:via_relation_class])
+      parent = relation_class.find(params[:via_record_id])
+
+      association_name = BaseResource.valid_association_name(parent, resource.model_key)
+
+      parent.send(association_name)
+    end
   end
 end
diff --git a/app/views/avo/partials/_table_header.html.erb b/app/views/avo/partials/_table_header.html.erb
index bafb43bc09..a29151f1bb 100644
--- a/app/views/avo/partials/_table_header.html.erb
+++ b/app/views/avo/partials/_table_header.html.erb
@@ -1,9 +1,3 @@
-<%
-  # Currently there isn't a way to summarize records on associations.
-  # We'd love to support this feature so please send in a PR.
-  should_summarize = @parent_record.blank?
-%>
-
 <thead
   data-component-name="avo/partials/table_header"
   class="bg-white border-b border-gray-200 pb-1">
@@ -83,14 +77,14 @@
             <%= field.table_header_label %>
           <% end %>
         <% end %>
-        <% if field.summarizable && should_summarize %>
+        <% if field.summarizable %>
           <div id="summary-header-<%= field.id %>" class="<%= text_classes %> cursor-pointer" data-action="click->toggle#togglePanel">
             <%= svg 'heroicons/solid/chart-bar', class: 'h-3 ml-1' %>
           </div>
           <turbo-frame
             id="summary-frame-<%= field.id %>"
             loading="lazy"
-            src="<%= distribution_chart_path(resource_name: field.resource.model_class, field_id: field.id) %>"
+            src="<%= distribution_chart_path(resource_name: field.resource.model_class, field_id: field.id, via_relation_class: @parent_record.class, via_record_id: @parent_record&.id) %>"
             class="absolute inset-auto bg-white w-full sm:w-[400px] top-0 mt-6 p-4 z-40 shadow-modal rounded overflow-hidden hidden border border-gray-50"
             data-toggle-target="panel"
           >
diff --git a/spec/features/avo/field_summarizing_spec.rb b/spec/features/avo/field_summarizing_spec.rb
index 46537a3971..1c92fd08ac 100644
--- a/spec/features/avo/field_summarizing_spec.rb
+++ b/spec/features/avo/field_summarizing_spec.rb
@@ -42,5 +42,42 @@
       expect(page).not_to have_css 'th[data-table-header-field-id="progress"] div svg'
       expect(page).not_to have_css 'th[data-table-header-field-id="description"] div svg'
     end
+
+    context "when summarizing on association pages" do
+      let(:user) { create :user }
+      let!(:project) { create :project, status: :closed, users: [user] }
+
+      it "only shows values from associated record" do
+        visit avo.resources_user_path(user)
+
+        scroll_to first_tab_group
+        click_tab "Projects", within_target: first_tab_group
+
+        wait_for_turbo_frame_id("has_and_belongs_to_many_field_show_projects")
+
+        expect(page).to have_css "turbo-frame[id='summary-frame-status']", visible: false
+
+        find("#summary-header-status").click
+
+        expect(page).to have_css "turbo-frame[id='summary-frame-status']", visible: true
+
+        # I can't make the lazy loading work, looks like it's not triggered at all
+        wait_for_turbo_frame_id("summary-frame-status")
+
+        expect(page).to have_css "#status-summary", visible: true
+        expect(page).to have_css "#chart-status", visible: true
+
+        within "#status-summary" do
+          expect(page).to_not have_content "REJECTED\n3"
+          expect(page).to have_content "CLOSED\n1"
+          expect(page).to_not have_content "LOADING\n4"
+        end
+
+        find('th[data-table-header-field-id="status"] div svg').click
+
+        expect(page).not_to have_css "#status-summary"
+        expect(page).not_to have_css "#chart-status"
+      end
+    end
   end
 end

From b3f357bb6c64349b9e847e5ec5699be8fbcb434c Mon Sep 17 00:00:00 2001
From: Thiago Youssef <43591948+thiagoyoussef@users.noreply.github.com>
Date: Tue, 19 Nov 2024 09:52:47 -0300
Subject: [PATCH 2/4] summarizable scoped query

---
 app/controllers/avo/charts_controller.rb | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/app/controllers/avo/charts_controller.rb b/app/controllers/avo/charts_controller.rb
index e450af5084..09f96811f2 100644
--- a/app/controllers/avo/charts_controller.rb
+++ b/app/controllers/avo/charts_controller.rb
@@ -3,7 +3,7 @@
 module Avo
   class ChartsController < BaseController
     def distribution_chart
-      @values_summary = records.group(params[:field_id]).reorder("count_all desc").count
+      @values_summary = scoped_query.group(params[:field_id].to_sym).reorder("count_all desc").count
 
       @field_id = params[:field_id]
 
@@ -12,11 +12,13 @@ def distribution_chart
 
     private
 
-    def records
+    def scoped_query
       if is_associated_record?
-        related_records
+        query = resource.authorization&.apply_policy related_records
+
+        Avo::ExecutionContext.new(target: resource.search_query, query: query).handle
       else
-        resource.model_class
+        resource.query_scope
       end
     end
 

From 610525ad4a9a54ed77842d8c957b61d12aa63436 Mon Sep 17 00:00:00 2001
From: Paul Bob <paul.ionut.bob@gmail.com>
Date: Mon, 2 Dec 2024 13:39:51 +0200
Subject: [PATCH 3/4] apply scope from parent field

---
 app/controllers/avo/charts_controller.rb      | 47 ++++++++++++++-----
 app/views/avo/partials/_table_header.html.erb | 10 +++-
 2 files changed, 43 insertions(+), 14 deletions(-)

diff --git a/app/controllers/avo/charts_controller.rb b/app/controllers/avo/charts_controller.rb
index 09f96811f2..8a9209b832 100644
--- a/app/controllers/avo/charts_controller.rb
+++ b/app/controllers/avo/charts_controller.rb
@@ -3,7 +3,7 @@
 module Avo
   class ChartsController < BaseController
     def distribution_chart
-      @values_summary = scoped_query.group(params[:field_id].to_sym).reorder("count_all desc").count
+      @values_summary = summary_query.group(params[:field_id].to_sym).reorder("count_all desc").count
 
       @field_id = params[:field_id]
 
@@ -12,23 +12,44 @@ def distribution_chart
 
     private
 
-    def scoped_query
-      if is_associated_record?
-        query = resource.authorization&.apply_policy related_records
+    def is_associated_summary
+      params[:via_record_id].present? &&
+      params[:via_resource_class].present? &&
+      params[:association_name].present?
+    end
 
-        Avo::ExecutionContext.new(target: resource.search_query, query: query).handle
-      else
-        resource.query_scope
-      end
+    def summary_query
+      is_associated_summary ? association_scope : resource.query_scope
     end
 
-    def related_records
-      relation_class = BaseResource.get_model_by_name(params[:via_relation_class])
-      parent = relation_class.find(params[:via_record_id])
+    def association_scope
+      parent_resource_class = Avo.resource_manager.get_resource(params[:via_resource_class])
+      parent_record = parent_resource_class.find_record(params[:via_record_id], params: params)
+
+      parent_resource = parent_resource_class.new(
+        record: parent_record,
+        # Explicitly hardcoding the view to 'show' as association summaries are processed solely within this context
+        view: Avo::ViewInquirer.new("show")
+      )
+
+      parent_resource.detect_fields
 
-      association_name = BaseResource.valid_association_name(parent, resource.model_key)
+      association_name = BaseResource.valid_association_name(parent_record, params[:association_name])
+
+      parent_field = find_association_field(resource: parent_resource, association: association_name)
+
+      association_query = parent_resource.authorization.apply_policy parent_record.send(association_name)
+
+      if parent_field.scope.present?
+        association_query = Avo::ExecutionContext.new(
+          target: parent_field.scope,
+          query: association_query,
+          parent: parent_record,
+          parent_resource: parent_resource
+        ).handle
+      end
 
-      parent.send(association_name)
+      association_query
     end
   end
 end
diff --git a/app/views/avo/partials/_table_header.html.erb b/app/views/avo/partials/_table_header.html.erb
index a29151f1bb..c02a8e1737 100644
--- a/app/views/avo/partials/_table_header.html.erb
+++ b/app/views/avo/partials/_table_header.html.erb
@@ -84,7 +84,15 @@
           <turbo-frame
             id="summary-frame-<%= field.id %>"
             loading="lazy"
-            src="<%= distribution_chart_path(resource_name: field.resource.model_class, field_id: field.id, via_relation_class: @parent_record.class, via_record_id: @parent_record&.id) %>"
+            src="<%= distribution_chart_path(
+              {
+                resource_name: field.resource.model_class,
+                field_id: field.id,
+                via_record_id: @parent_record&.to_param,
+                via_resource_class: @parent_resource&.class&.to_s,
+                association_name: @field&.for_attribute || @field&.id
+              }.compact
+            ) %>"
             class="absolute inset-auto bg-white w-full sm:w-[400px] top-0 mt-6 p-4 z-40 shadow-modal rounded overflow-hidden hidden border border-gray-50"
             data-toggle-target="panel"
           >

From 07c11f8f5983c323efb558872fd69b4a1bda4f7f Mon Sep 17 00:00:00 2001
From: Paul Bob <paul.ionut.bob@gmail.com>
Date: Mon, 2 Dec 2024 13:42:41 +0200
Subject: [PATCH 4/4] lint

---
 app/controllers/avo/charts_controller.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/controllers/avo/charts_controller.rb b/app/controllers/avo/charts_controller.rb
index 8a9209b832..37bfe0c0a4 100644
--- a/app/controllers/avo/charts_controller.rb
+++ b/app/controllers/avo/charts_controller.rb
@@ -14,8 +14,8 @@ def distribution_chart
 
     def is_associated_summary
       params[:via_record_id].present? &&
-      params[:via_resource_class].present? &&
-      params[:association_name].present?
+        params[:via_resource_class].present? &&
+        params[:association_name].present?
     end
 
     def summary_query