Only remove attachment upload button after trix has initialized

[iainbeeston]

Description

I'm finding that when attachments are disabled the trix field controller is trying to remove the attachments button before trix has initialized and before it has created the toolbar. This crashes the controller inside the connect method and so none of the other event listeners are set up and the attach files button isn't removed.

NOTE: I haven't been able to test this myself, the code is my best guess at how to fix the issue.

Fixes # (issue)

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

1. Find a resource with a trix field
2. Make sure it shows an attachment button
3. Disable attachments
4. Make sure the attachment button is now hidden

Manual reviewer: please leave a comment with output from the test if that's the case.

[codeclimate]

Code Climate has analyzed commit 74c0b69 and detected 0 issues on this pull request.

View more on Code Climate.