Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA to test changes compatibility with avocado-vt #5233

Open
ana opened this issue Jan 19, 2022 · 2 comments
Open

Add GHA to test changes compatibility with avocado-vt #5233

ana opened this issue Jan 19, 2022 · 2 comments

Comments

@ana
Copy link
Contributor

ana commented Jan 19, 2022

Add a new GH Actions that can be run on-demand to test compatibility with avocado-vt

Reference discussion: avocado-framework/avocado-vt#3295

@ana ana self-assigned this Jan 19, 2022
ana added a commit to ana/avocado that referenced this issue Jan 19, 2022
Initial action testing a given branch from the current avocado
repository against master branch from
https://github.com/avocado-framework/avocado-vt

References: avocado-framework#5233

Signed-off-by: Ana Guerrero Lopez <[email protected]>
ana added a commit to ana/avocado that referenced this issue Jan 19, 2022
Initial action testing an avocado development branch against
the master branch from https://github.com/avocado-framework/avocado-vt

References: avocado-framework#5233

Signed-off-by: Ana Guerrero Lopez <[email protected]>
@ana ana added this to the #95(PAW Patrol: The Movie) milestone Jan 19, 2022
clebergnu pushed a commit to clebergnu/avocado that referenced this issue Jan 26, 2022
Initial action testing an avocado development branch against
the master branch from https://github.com/avocado-framework/avocado-vt

References: avocado-framework#5233

Signed-off-by: Ana Guerrero Lopez <[email protected]>
ana added a commit to ana/avocado that referenced this issue Jan 28, 2022
Initial action testing an avocado development branch against
the master branch from https://github.com/avocado-framework/avocado-vt

References: avocado-framework#5233

Signed-off-by: Ana Guerrero Lopez <[email protected]>
@ana ana removed this from the #95(PAW Patrol: The Movie) milestone Jan 31, 2022
@ana
Copy link
Contributor Author

ana commented Feb 1, 2022

I proposed a PR #5234 with a re-using the ansible deployment playbook.
That idea was discarded, some other ideas for the record:

@ana thanks for coming up with this. The idea of reusing the "deployment checks", AKA ansible playbooks, is great. I tried it out, and worked great.

But there's one limitation of GHA (and pretty much every other free CI offering): it lacks KVM support. And, it's very hard to go deep into Avocado-VT, and prove compatibility, without KVM. I've tried to use TCG to run say a boot test in Avocado-VT and did not have reliable results. The KVM support on Cirrus-CI, on the other hand, has been running smoothly for a good amount of time.

So, while this is certainly helpful, the platform limitation is a concern. We may be better served at this point by having a copy (or subset) of the Avocado-VT Cirrus-CI set to manual or allowing them to fail.

PS: my dream solution would be to not add anything in the Avocado repository, but allow manual triggers (like GHA allow) on the Avocado-VT repo, pointing at the branch of a given PR.

Comments?

Hi @clebergnu

Thanks for your comment. Do you mind copying into #5233 ? Or even opening a new issue with your dream solution more detailed (dreaming is free!). And I'll think what we can do.

In the meantime, looks like github is considering to offer nested virtualization github/feedback#8305 If we have the possibility to have a self-hosted runner for tests like this one, it would be also another possible solution.

Hi @clebergnu

Thanks for your comment. Do you mind copying into #5233 ? Or even opening a new issue with your dream solution more detailed (dreaming is free!). And I'll think what we can do.

Sure!

In the meantime, looks like github is considering to offer nested virtualization github/feedback#8305 If we have the possibility to have a self-hosted runner for tests like this one, it would be also another possible solution.

The move from GH is interesting, that would be great! Let's keep an eye on it. About the self-hosted runner, it's something to be considered indeed. Let assess the resources availability (especially the maintenance aspects).

Thanks for all the info.

@ana
Copy link
Contributor Author

ana commented May 2, 2022

An initial approach for this could be adding a test that will run in a self-hosted runner while github adds support for virtualization.

@ana ana removed their assignment May 2, 2022
@richtja richtja moved this to Short Term (Current Q) Backlog in Default project Dec 15, 2022
@clebergnu clebergnu moved this from Short Term (Current Q) Backlog to Long Term (Next Q) Backlog in Default project Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Long Term (Next Q) Backlog
Development

No branches or pull requests

1 participant