Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrollment - Learning #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thanhbao922003
Copy link
Contributor

Checklist tự review pull trước khi ready để trainer review

  • Kiểm tra mỗi pull request chỉ 1 commit, nếu nhiều hơn 1 commit thì hãy gộp commit thành 1 rồi đẩy lại lên git
  • Chạy eslint ở local để check và fix các lỗi liên quan đến syntax, coding convention. Khi gửi thì chụp ảnh PASS eslint đính kèm trong pull
  • Sử dụng thụt lề 2 spaces/4 spaces đồng nhất ở tất cả các files (setting lại vscode /sublime text nếu chưa cài đặt)
  • Cuối mỗi file kiểm tra có end line (khi đẩy lên git xem file change không bị lỗi tròn đỏ ở cuối file)
  • Mỗi dòng nếu quá dài, cần xuống dòng (maximum: 80 kí tự mỗi dòng, setting trong IDE hoặc dùng Prettier để config format code)
  • Tham khảo Typescript coding convention https://google.github.io/styleguide/tsguide.html

Related Tickets

  • ticket redmine

WHAT (optional)

  • Change number items completed/total in admin page.

HOW

  • I edit js file, inject not_vary_normal items in calculate function.

WHY (optional)

  • Because in previous version - number just depends on normal items. But in new version, we have state and confirm_state depends on both normal + not_normal items.

Evidence (Screenshot or Video)

Notes (Kiến thức tìm hiểu thêm)

@thanhbao922003 thanhbao922003 force-pushed the review_comment_component branch from 6dca9dc to 98693db Compare October 9, 2024 07:24
@thanhbao922003
Copy link
Contributor Author

ready

2 similar comments
@thanhbao922003
Copy link
Contributor Author

ready

@thanhbao922003
Copy link
Contributor Author

ready

Copy link
Contributor

@huongnt-2545 huongnt-2545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull này PENDING em nhé,
như chị có trao đổi trong thread nha

@thanhbao922003 thanhbao922003 force-pushed the review_comment_component branch from c5608fa to 3d596b9 Compare October 10, 2024 16:43
@thanhbao922003 thanhbao922003 changed the title CRUD: Review - Comment - Component Enrollment - Learning Oct 10, 2024
@thanhbao922003
Copy link
Contributor Author

ready

CreateDateColumn,
UpdateDateColumn,
} from 'typeorm';
import { Entity,Column, PrimaryGeneratedColumn, ManyToOne, JoinColumn, CreateDateColumn, UpdateDateColumn, } from 'typeorm';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

các bạn trong nhóm dùng chung setting trên VScode để tránh bị re-format code khi push nha

export const enrollInCourse = asyncHandler(async (req: Request, res: Response) => {
const { userId, courseId } = req.body;
const enrollment = await enrollmentService.enrollUserInCourse(userId, courseId);
res.status(201).json({ message: 'Enrolled successfully', enrollment });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chưa có xử lý về mặt giao diện à e ơi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants