-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrollment - Learning #5
base: master
Are you sure you want to change the base?
Enrollment - Learning #5
Conversation
6dca9dc
to
98693db
Compare
ready |
2 similar comments
ready |
ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull này PENDING em nhé,
như chị có trao đổi trong thread nha
c5608fa
to
3d596b9
Compare
ready |
CreateDateColumn, | ||
UpdateDateColumn, | ||
} from 'typeorm'; | ||
import { Entity,Column, PrimaryGeneratedColumn, ManyToOne, JoinColumn, CreateDateColumn, UpdateDateColumn, } from 'typeorm'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
các bạn trong nhóm dùng chung setting trên VScode để tránh bị re-format code khi push nha
export const enrollInCourse = asyncHandler(async (req: Request, res: Response) => { | ||
const { userId, courseId } = req.body; | ||
const enrollment = await enrollmentService.enrollUserInCourse(userId, courseId); | ||
res.status(201).json({ message: 'Enrolled successfully', enrollment }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chưa có xử lý về mặt giao diện à e ơi
Checklist tự review pull trước khi ready để trainer review
Related Tickets
WHAT (optional)
completed/total
in admin page.HOW
WHY (optional)
normal
items. But in new version, we havestate
andconfirm_state
depends on bothnormal
+not_normal
items.Evidence (Screenshot or Video)
Notes (Kiến thức tìm hiểu thêm)