fix: disallow Gen 1 Patterns in GraphQL SDL schema. #1719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d115d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
edwardfoyle
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Couple small comments. My main concern is that this is a breaking change even if the product team doesn't want to release it as such. Do we have data around how many customers have a gen 1 schema in gen 2? Should we print a warning saying that this behavior will be removed in a future major version instead?
| schema, | ||
| }); | ||
| assert.throws(() => dataFactory.getInstance(getInstanceProps), { | ||
| message: 'Failed to instantiate data construct', |
There was a problem hiding this comment.
Can we throw an error message that explains what is not supported and how to fix it?
.changeset/unlucky-otters-hide.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@aws-amplify/backend-data': patch | |||
There was a problem hiding this comment.
Suggested change
| '@aws-amplify/backend-data': patch | |
| '@aws-amplify/backend-data': minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Customers can use Gen 1 patterns in GraphQL SDL string schema. This is not intentional.
Issue number, if available: N/A
Changes
Disallows usage of specific gen 1 patterns. See aws-amplify/amplify-category-api#2670 for list.
Corresponding docs PR, if applicable: aws-amplify/docs#7793
Validation
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.