Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Domain Name is missing in outputs if name is specified for Auth Stack #1745

Closed
wants to merge 3 commits into from

Conversation

awsluja
Copy link
Contributor

@awsluja awsluja commented Jul 15, 2024

Problem

If a name is provided to the top level stack, the underlying resource names are affected, which causes 'tryFindChild' to fail. This fix accounts for the 'name' property if it is used.
#1724

Changes

Updates the tryFindChild('UserPoolDomain') to tryFindChild(${this.name}UserPoolDomain) to account for the optional name property.

Validation

Tests have been added to check for impact when using 'name' property.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@awsluja awsluja added the run-e2e Label that will include e2e tests in PR checks workflow label Jul 15, 2024
@awsluja awsluja requested a review from a team as a code owner July 15, 2024 18:16
Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: 49712b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/auth-construct Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@awsluja awsluja closed this Jul 15, 2024
@sobolk sobolk deleted the run-e2e/aluja/oauth-domain-output-fix branch December 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant