Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate prefer-amplify-errors #1986

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

ShadowCat567
Copy link
Contributor

@ShadowCat567 ShadowCat567 commented Sep 10, 2024

Problem

prefer-amplify-errors was previously inactive for the entire project, was also too sensitive and triggering on code it was not supposed to.
Issue number, if available: N/A

Changes

  • prefer-amplify-errors is now active in 5 packages
  • the former violation in create-amplify is now an AmplifyUserError instead of Error
  • the violation in backend-deployer is suppressed until someone can take another look at it
  • violations in backend-ai and backend-auth are suppressed, are not problems the linter should flag
    Corresponding docs PR, if applicable: N/A

Validation

linter is happy with the changes

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 67999b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@aws-amplify/backend-deployer Patch
create-amplify Patch
@aws-amplify/backend-auth Patch
@aws-amplify/backend-ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ShadowCat567 ShadowCat567 marked this pull request as ready for review September 11, 2024 16:09
@ShadowCat567 ShadowCat567 requested a review from a team as a code owner September 11, 2024 16:09
@ShadowCat567 ShadowCat567 merged commit c85d071 into aws-amplify:main Sep 11, 2024
37 checks passed
@ShadowCat567 ShadowCat567 deleted the prefer-amplify-errors branch September 11, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants