Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify pointing client config generator at metadata-less stack as u… #2024

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Sep 18, 2024

…ser error

Problem

Absence of metadata in a stack implies that CLI / config generator was pointed to a stack that was not created by Amplify.

Changes

Classify such error as user error.

Validation

Added test.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner September 18, 2024 19:22
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 622ff09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/client-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sobolk sobolk merged commit 603b75d into main Sep 18, 2024
38 checks passed
@sobolk sobolk deleted the classify-non-amplify-stack-errors branch September 18, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants